Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(running renovate): rewrite #21222

Merged
merged 28 commits into from May 20, 2023
Merged

docs(running renovate): rewrite #21222

merged 28 commits into from May 20, 2023

Conversation

HonkingGoose
Copy link
Collaborator

Changes

  • Rewrite:
    • Use simple words and phrases
    • Create sections for Docker Hub full and slim images
    • Re-order some text to put the important/most used stuff up front

Context

Drive by PR, not fixing any issue with this.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

rarkins
rarkins requested changes Apr 1, 2023
View reviewed changes
docs/usage/getting-started/running.md Outdated Show resolved Hide resolved
docs/usage/getting-started/running.md Outdated Show resolved Hide resolved
viceice
viceice previously requested changes Apr 1, 2023
View reviewed changes
docs/usage/getting-started/running.md Outdated Show resolved Hide resolved
docs/usage/getting-started/running.md Outdated Show resolved Hide resolved
@HonkingGoose @viceice @rarkins
Apply suggestions from maintainers
89a1a78 
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Rhys Arkins <rhys@arkins.net>
@HonkingGoose HonkingGoose mentioned this pull request Apr 3, 2023
Closed
viceice
viceice reviewed Apr 3, 2023
View reviewed changes
docs/usage/getting-started/running.md Show resolved Hide resolved
docs/usage/getting-started/running.md Outdated Show resolved Hide resolved
docs/usage/getting-started/running.md Outdated Show resolved Hide resolved
@HonkingGoose @viceice
Default image only has most package managers
d6149c1 
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
viceice
viceice reviewed Apr 6, 2023
View reviewed changes
docs/usage/getting-started/running.md Outdated Show resolved Hide resolved
docs/usage/getting-started/running.md Outdated Show resolved Hide resolved
docs/usage/getting-started/running.md Outdated Show resolved Hide resolved
docs/usage/getting-started/running.md Outdated Show resolved Hide resolved
docs/usage/getting-started/running.md Show resolved Hide resolved
HonkingGoose and others added 5 commits April 7, 2023 08:44
@HonkingGoose @viceice
Use dummy domain name for gitAuthor
3545bb1 
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@HonkingGoose
Refert to binarySource=global for global mode
44b6056
@HonkingGoose
Explain how to invoke sidecar images
7d4f159
@HonkingGoose @viceice
Mention classic PAT
a579349 
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@HonkingGoose
Use relative link
8f46a73
rarkins
rarkins requested changes Apr 19, 2023
View reviewed changes
docs/usage/getting-started/running.md Outdated Show resolved Hide resolved
rarkins
rarkins previously approved these changes May 18, 2023
View reviewed changes
HonkingGoose
HonkingGoose commented May 18, 2023
View reviewed changes
Copy link
Collaborator Author

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more things and then we're good to go, finally. 😄

docs/usage/getting-started/running.md Outdated Show resolved Hide resolved
docs/usage/getting-started/running.md Outdated Show resolved Hide resolved
@HonkingGoose HonkingGoose marked this pull request as ready for review May 18, 2023 09:20
rarkins
rarkins requested changes May 18, 2023
View reviewed changes
docs/usage/getting-started/running.md Outdated Show resolved Hide resolved
@HonkingGoose @rarkins
Update docs/usage/getting-started/running.md
246a109 
Co-authored-by: Rhys Arkins <rhys@arkins.net>
rarkins
rarkins requested changes May 19, 2023
View reviewed changes
docs/usage/getting-started/running.md Outdated Show resolved Hide resolved
rarkins
rarkins previously approved these changes May 19, 2023
View reviewed changes
@rarkins rarkins enabled auto-merge May 19, 2023 18:10
@rarkins rarkins requested a review from viceice May 19, 2023 18:10
@rarkins @HonkingGoose
Update docs/usage/getting-started/running.md
d1e4620 
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@HonkingGoose
Copy link
Collaborator Author

This is good to go now. 🙂

@rarkins rarkins added this pull request to the merge queue May 20, 2023
Merged via the queue into renovatebot:main with commit 43669f8 May 20, 2023
11 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.97.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@HonkingGoose HonkingGoose deleted the docs/rewrite-running-renovate branch May 20, 2023 07:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rarkins rarkins rarkins approved these changes

@viceice viceice Awaiting requested review from viceice

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@HonkingGoose @renovate-release @viceice @rarkins