Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default platformAutomerge=true #21319

Closed
Tracked by #21134
rarkins opened this issue Apr 4, 2023 · 2 comments · Fixed by #21327
Closed
Tracked by #21134

Default platformAutomerge=true #21319

rarkins opened this issue Apr 4, 2023 · 2 comments · Fixed by #21327
Assignees
@rarkins
Labels
breaking Breaking change, requires major version bump priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:in-progress Someone is working on implementation type:refactor Refactoring or improving of existing code v36

Comments

@rarkins
Copy link
Collaborator

rarkins commented Apr 4, 2023

Describe the proposed change(s).

Leave this as a configurable option, but default it to true instead of false.
@rarkins rarkins added priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:refactor Refactoring or improving of existing code breaking Breaking change, requires major version bump status:ready labels Apr 4, 2023
@viceice viceice mentioned this issue Apr 4, 2023
Closed
28 tasks
@HonkingGoose
Copy link
Collaborator

We should also rewrite the Faster merges with platform-native automerge section 1. That section was written when the default was false. 😉

Footnotes

  1. Renovate docs, faster merges with platform-native automerge ↩

rarkins added a commit that referenced this issue Apr 4, 2023
@rarkins
feat(automerge)!: default to platformAutomerge=true
3bd509e 
Closes #21319

BREAKING CHANGE: Platform automerge is now used by default when PR automerge is configured
@rarkins rarkins mentioned this issue Apr 4, 2023
Merged
6 tasks
@rarkins rarkins self-assigned this Apr 4, 2023
@rarkins rarkins added status:in-progress Someone is working on implementation and removed status:ready labels Apr 4, 2023
@rarkins rarkins closed this as completed Jun 12, 2023
@rarkins rarkins reopened this Jun 12, 2023
@rarkins rarkins added the v36 label Jun 12, 2023
rarkins added a commit that referenced this issue Jul 4, 2023
@rarkins
feat(automerge)!: default to platformAutomerge=true (#21327)
0cb3c58 
Closes #21319

BREAKING CHANGE: Platform automerge will now be chosen by default whenever automerge is enabled.
@rarkins rarkins closed this as completed in 61a7813 Jul 4, 2023
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 36.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot mentioned this issue Jul 9, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rarkins rarkins

Labels
breaking Breaking change, requires major version bump priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:in-progress Someone is working on implementation type:refactor Refactoring or improving of existing code v36
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(automerge)!: default to platformAutomerge=true renovatebot/renovate
3 participants
@rarkins @HonkingGoose @renovate-release