Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default allowPostUpgradeCommandTemplating to true #21320

Closed
Tracked by #21134
rarkins opened this issue Apr 4, 2023 · 1 comment · Fixed by #21326
Closed
Tracked by #21134

Default allowPostUpgradeCommandTemplating to true #21320

rarkins opened this issue Apr 4, 2023 · 1 comment · Fixed by #21326
Assignees
@rarkins
Labels
breaking Breaking change, requires major version bump priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:refactor Refactoring or improving of existing code v36

Comments

@rarkins
Copy link
Collaborator

rarkins commented Apr 4, 2023

Describe the proposed change(s).

This should not change allowedPostUpgradeCommands's effect, but just mean that by default templating is allowed if allowedPostUpgradeCommands patterns match.
@rarkins rarkins added priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:refactor Refactoring or improving of existing code breaking Breaking change, requires major version bump status:ready labels Apr 4, 2023
@viceice viceice mentioned this issue Apr 4, 2023
Closed
28 tasks
@rarkins rarkins self-assigned this Apr 4, 2023
rarkins added a commit that referenced this issue Apr 4, 2023
@rarkins
feat!: allow post upgrade templating by default
3110377 
Closes #21320

BREAKING CHANGE: The dafault value for allowPostUpgradeCommandTemplating has changed from false to true.
@rarkins rarkins mentioned this issue Apr 4, 2023
Merged
6 tasks
@rarkins rarkins added the v36 label Jun 12, 2023
rarkins added a commit that referenced this issue Jul 4, 2023
@rarkins
feat!: allow post upgrade templating by default (#21326)
5323633 
Closes #21320

BREAKING CHANGE: Post upgrade templating is now allowed by default, as long as the post upgrade task command is itself already allowed.
@rarkins rarkins closed this as completed in 6a95024 Jul 4, 2023
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 36.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot mentioned this issue Jul 9, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rarkins rarkins

Labels
breaking Breaking change, requires major version bump priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:refactor Refactoring or improving of existing code v36
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: allow post upgrade templating by default renovatebot/renovate
2 participants
@rarkins @renovate-release