Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: allow post upgrade templating by default #21326

Merged
merged 3 commits into from
Apr 5, 2023

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Apr 4, 2023

Changes

BREAKING CHANGE: The dafault value for allowPostUpgradeCommandTemplating has changed from false to true.

Context

Closes #21320

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Closes #21320

BREAKING CHANGE: The dafault value for allowPostUpgradeCommandTemplating has changed from false to true.
@rarkins rarkins changed the base branch from main to v36 April 4, 2023 10:25
@rarkins rarkins added the breaking Breaking change, requires major version bump label Apr 4, 2023
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@rarkins rarkins added this pull request to the merge queue Apr 5, 2023
Merged via the queue into v36 with commit d11731c Apr 5, 2023
6 checks passed
@rarkins rarkins deleted the feat/21320-post-upgrade-templating-default branch April 5, 2023 05:13
rarkins added a commit that referenced this pull request Apr 26, 2023
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking Breaking change, requires major version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default allowPostUpgradeCommandTemplating to true
3 participants