Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(devcontainer): Fixed errors and added CI workflow #21515

Merged
merged 11 commits into from Apr 17, 2023
Merged

chore(devcontainer): Fixed errors and added CI workflow #21515

merged 11 commits into from Apr 17, 2023

Conversation

lmilbaum
Copy link
Contributor

@lmilbaum lmilbaum commented Apr 14, 2023 •
edited

Changes

  1. Dev container is running on Mac M1 box
  2. Dev container is validated by devcontainer GHA workflow
  3. Reduced the memory requirements for running a dev container

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@lmilbaum lmilbaum force-pushed the devcontainer branch 2 times, most recently from 92b9f1b to eec76dc Compare April 14, 2023 13:31
viceice
viceice reviewed Apr 14, 2023
View reviewed changes
.devcontainer/Dockerfile Outdated Show resolved Hide resolved
.github/workflows/devcontainer.yml Outdated Show resolved Hide resolved
.github/workflows/devcontainer.yml Outdated Show resolved Hide resolved
.devcontainer/Dockerfile Outdated Show resolved Hide resolved
@lmilbaum lmilbaum force-pushed the devcontainer branch 9 times, most recently from 907a884 to e529ab5 Compare April 14, 2023 18:05
viceice
viceice requested changes Apr 14, 2023
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moving files to repo root is not an option

@lmilbaum lmilbaum force-pushed the devcontainer branch 13 times, most recently from edcd2d5 to 00bba0a Compare April 15, 2023 05:15
viceice
viceice reviewed Apr 15, 2023
View reviewed changes
.devcontainer/Dockerfile Outdated Show resolved Hide resolved
.devcontainer/Dockerfile Outdated Show resolved Hide resolved
.devcontainer/Dockerfile Outdated Show resolved Hide resolved
.devcontainer/Dockerfile Outdated Show resolved Hide resolved
@lmilbaum lmilbaum force-pushed the devcontainer branch 2 times, most recently from 0908525 to 862c8c5 Compare April 15, 2023 10:26
viceice
viceice requested changes Apr 15, 2023
View reviewed changes
.devcontainer/Dockerfile Outdated Show resolved Hide resolved
.devcontainer/Dockerfile Outdated Show resolved Hide resolved
.devcontainer/Dockerfile Outdated Show resolved Hide resolved
.devcontainer/devcontainer.json Outdated Show resolved Hide resolved
@lmilbaum lmilbaum requested a review from viceice April 15, 2023 20:03
viceice
viceice reviewed Apr 16, 2023
View reviewed changes
.devcontainer/devcontainer.json Outdated Show resolved Hide resolved
.github/workflows/devcontainer.yml Outdated Show resolved Hide resolved
.github/workflows/devcontainer.yml Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
lmilbaum and others added 5 commits April 16, 2023 20:24
@lmilbaum @viceice
Update .devcontainer/devcontainer.json
f33a2e8 
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@lmilbaum
Merge branch 'main' into devcontainer
a2bb850
@lmilbaum @viceice
Update .github/workflows/devcontainer.yml
aa711af 
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@lmilbaum @viceice
Update .github/workflows/devcontainer.yml
611f892 
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@lmilbaum
revert package.json
bef3659
@lmilbaum lmilbaum requested a review from viceice April 16, 2023 18:04
@viceice viceice requested a review from JamieMagee April 16, 2023 18:20
@JamieMagee
Copy link
Contributor

GitHub hosted macOS ARM runners are currently in public preview1. I opened an issue upstream with node-re2 asking for pre-compiled binaries: uhop/node-re2#164

Footnotes

  1. https://github.com/github/roadmap/issues/528 ↩

lmilbaum and others added 2 commits April 17, 2023 06:17
@JamieMagee JamieMagee added this pull request to the merge queue Apr 17, 2023
Merged via the queue into renovatebot:main with commit 93e8bda Apr 17, 2023
11 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.50.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot mentioned this pull request May 2, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JamieMagee JamieMagee JamieMagee approved these changes

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lmilbaum @JamieMagee @renovate-release @viceice