Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(composer): Use schema for parsing #21520

Merged
merged 25 commits into from May 7, 2023
Merged

refactor(composer): Use schema for parsing #21520

merged 25 commits into from May 7, 2023

Conversation

zharinov
Copy link
Collaborator

Changes

  • Use schema library instead of relying on JSON.parse + type cast

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov
Copy link
Collaborator Author

Data schemas for composer are quite complicated, because they support two parallel formats at the same time (array + record)

@zharinov zharinov requested a review from viceice April 14, 2023 16:32
@zharinov zharinov marked this pull request as draft April 14, 2023 16:34
viceice
viceice reviewed Apr 14, 2023
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready or not ready for review?

@zharinov zharinov marked this pull request as ready for review April 16, 2023 13:55
@zharinov zharinov requested a review from viceice April 16, 2023 13:55
@zharinov zharinov marked this pull request as draft April 16, 2023 14:20
viceice
viceice reviewed Apr 18, 2023
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocked by other PR

@zharinov
Merge branch 'main' into refactor/composer-manager-schema
8aac47b 
# Conflicts:
#	lib/util/schema-utils.spec.ts
#	lib/util/schema-utils.ts
@zharinov
Fix merge
dff4deb
@zharinov zharinov marked this pull request as ready for review April 21, 2023 09:01
@zharinov zharinov requested a review from viceice April 21, 2023 09:02
viceice
viceice reviewed Apr 21, 2023
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very big and hard to review. can we split to smaller parts?

lib/modules/manager/composer/schema.ts Show resolved Hide resolved
lib/modules/manager/composer/schema.ts Outdated Show resolved Hide resolved
@zharinov
Copy link
Collaborator Author

I don't see a meaningful way to split it into different parts

@viceice
Copy link
Member

viceice commented Apr 21, 2023

I don't see a meaningful way to split it into different parts

ok, so it'll need some time to review 🤷‍♂️

@zharinov zharinov requested a review from viceice May 6, 2023 15:01
viceice
viceice reviewed May 6, 2023
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

lib/modules/manager/composer/extract.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/composer/schema.ts Outdated Show resolved Hide resolved
@zharinov zharinov requested a review from viceice May 6, 2023 18:46
@rarkins rarkins enabled auto-merge May 7, 2023 05:16
@rarkins rarkins added this pull request to the merge queue May 7, 2023
Merged via the queue into renovatebot:main with commit 664dc80 May 7, 2023
11 checks passed
@rarkins rarkins deleted the refactor/composer-manager-schema branch May 7, 2023 21:11
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.73.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

mjunker pushed a commit to mjunker/renovate that referenced this pull request May 17, 2023
@zharinov @mjunker
refactor(composer): Use schema for parsing (renovatebot#21520)
6c9f340
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rarkins rarkins rarkins left review comments

@viceice viceice viceice approved these changes

@JamieMagee JamieMagee Awaiting requested review from JamieMagee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zharinov @viceice @renovate-release @rarkins