Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ansible-galaxy): handle git source #21640

Merged
merged 2 commits into from Apr 21, 2023
Merged

fix(ansible-galaxy): handle git source #21640

merged 2 commits into from Apr 21, 2023

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Apr 21, 2023

Changes

Adds logic for when a git source is in the collections.value field in ansible galaxy

Context

Fixes #21580

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested a review from secustor April 21, 2023 04:16
Copy link
Collaborator

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is no version in that case on the result. The best place to add this functionality would be: https://github.com/renovatebot/renovate/blob/main/lib/modules/manager/ansible-galaxy/collections.ts#L47

@secustor secustor added this pull request to the merge queue Apr 21, 2023
Merged via the queue into main with commit bf0e39d Apr 21, 2023
12 checks passed
@secustor secustor deleted the fix/21580-git-source branch April 21, 2023 09:49
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.56.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants