Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager/gradle): Support properties map in gradle kts #21792

Merged
merged 5 commits into from May 7, 2023

Conversation

guicamest
Copy link
Contributor

@guicamest guicamest commented Apr 24, 2023

Changes

Adds support for properties accessor. Gradle ref available here (thx @Churro)

Context

Related to this discussion.
TL;DR;

Given a gradle.properties file that declares a version for a dependency:

...
mockitoKotlin=4.0.0

and a build.gradle.kts that declares a dependency that uses that property via the properties map:

dependencies {
   ...
   testImplementation("org.mockito.kotlin:mockito-kotlin:${properties["mockitoKotlin"]}")
   ...
}

I would like Renovate to raise a PR to update mockitoKotlin to the latest version (current is 4.1.0)

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Sample repository: https://github.com/guicamest/gradle-kts-properties-renovate-repro

@viceice viceice requested review from Churro and zharinov April 25, 2023 04:05
Churro
Churro previously approved these changes Apr 26, 2023
lib/modules/manager/gradle/parser.spec.ts Outdated Show resolved Hide resolved
@guicamest guicamest requested a review from viceice May 7, 2023 14:35
@rarkins rarkins added this pull request to the merge queue May 7, 2023
Merged via the queue into renovatebot:main with commit 2112ea2 May 7, 2023
11 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.73.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@guicamest guicamest deleted the gradle-kts-properties-map branch May 7, 2023 17:17
mjunker pushed a commit to mjunker/renovate that referenced this pull request May 17, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants