Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency glob to v10 #21865

Merged
merged 5 commits into from May 2, 2023
Merged

chore(deps): update dependency glob to v10 #21865

merged 5 commits into from May 2, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 28, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
glob 8.1.0 -> 10.2.1 age adoption passing confidence

Release Notes

isaacs/node-glob

v10.2.1

Compare Source

v10.2.0

Compare Source

  • Add glob cli

v10.1.0

Compare Source

  • Return '.' instead of the empty string '' when the current
    working directory is returned as a match.
  • Add posix: true option to return / delimited paths, even on
    Windows.

v10.0.0

Compare Source

  • No default exports, only named exports

v9.3.5

Compare Source

v9.3.4

Compare Source

v9.3.3

Compare Source

  • Upgraded minimatch to v8, adding support for any degree of
    nested extglob patterns.

v9.3.2

Compare Source

v9.3.1

Compare Source

v9.3.0

Compare Source

v9.2.1

Compare Source

v9.2.0

Compare Source

v9.1.2

Compare Source

v9.1.1

Compare Source

v9.1.0

Compare Source

v9.0.2

Compare Source

v9.0.1

Compare Source

v9.0.0

Compare Source


Configuration

πŸ“… Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

β™» Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

πŸ”• Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@viceice
Copy link
Member

viceice commented Apr 28, 2023

@rarkins @secustor @JamieMagee Thinking of dropping shelljs in favor of node buildins.

Currently shelljs depends on old glob v7, so we get types trouble πŸ˜•

@viceice viceice mentioned this pull request Apr 28, 2023
6 tasks
@viceice viceice enabled auto-merge April 28, 2023 13:36
viceice
viceice previously approved these changes Apr 28, 2023
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove the minimatch types again in the minimatch major bump later

@viceice viceice added this pull request to the merge queue Apr 28, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 28, 2023
@JamieMagee
Copy link
Contributor

@viceice It looks like v10 dropped the default export in favour of named exports only.

@viceice
Copy link
Member

viceice commented Apr 28, 2023

renovate bot removed my changes πŸ€”

@viceice viceice enabled auto-merge April 28, 2023 15:50
viceice
viceice previously approved these changes Apr 28, 2023
@renovate
Copy link
Contributor Author

renovate bot commented Apr 28, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠ Warning: custom changes will be lost.

@viceice viceice added this pull request to the merge queue Apr 28, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 28, 2023
@viceice viceice added this pull request to the merge queue Apr 28, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 28, 2023
@viceice viceice added this pull request to the merge queue Apr 28, 2023
@viceice
Copy link
Member

viceice commented Apr 28, 2023

what's happening here, it gets removed from queue every time πŸ€”

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 28, 2023
@viceice viceice added this pull request to the merge queue Apr 28, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 28, 2023
@HonkingGoose
Copy link
Collaborator

what's happening here, it gets removed from queue every time πŸ€”

@viceice that's actually good, because test (windows-latest) fails. GitHub Merge Queue should not merge if the tests fail. πŸ˜„

Here's the relevant part of the logs:

Run yarn build
yarn run v1.22.19
$ run-s clean generate:* compile:* create-json-schema
$ rimraf dist tmp
$ node tools/generate-imports.mjs
generating imports
> data/azure-pipelines-tasks.json
> data/debian-distro-info.json
> data/kubernetes-api.json5
> data/node-js-schedule.json
> data/ubuntu-distro-info.json
> node_modules/emojibase-data/en/shortcodes/github.json
generating hashes
$ tsc -p tsconfig.app.json
Error: lib/modules/datasource/azure-pipelines-tasks/index.ts(1,23): error TS2307: Cannot find module '../../../data-files.generated' or its corresponding type declarations.
Error: lib/modules/datasource/kubernetes-api/index.ts(2,23): error TS2307: Cannot find module '../../../data-files.generated' or its corresponding type declarations.
Error: lib/modules/manager/index.ts(13,25): error TS2307: Cannot find module './fingerprint.generated' or its corresponding type declarations.
Error: lib/modules/versioning/distro.ts(2,37): error TS2307: Cannot find module '../../data-files.generated' or its corresponding type declarations.
Error: lib/modules/versioning/node/schedule.ts(1,23): error TS2307: Cannot find module '../../../data-files.generated' or its corresponding type declarations.
Error: lib/util/emoji.ts(12,23): error TS2307: Cannot find module '../data-files.generated' or its corresponding type declarations.
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
ERROR: "compile:ts" exited with 2.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error: Process completed with exit code 1.

By the way, you can click the blue text "View details" button to view the tests that ran in the GitHub Merge Queue. πŸ˜‰

Source: https://github.com/renovatebot/renovate/actions/runs/4832879783/jobs/8612206416

@viceice
Copy link
Member

viceice commented Apr 29, 2023

i know, but I'm confused by that error. πŸ€”

@viceice viceice enabled auto-merge May 2, 2023 09:07
@viceice viceice added this pull request to the merge queue May 2, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 2, 2023
@viceice viceice added this pull request to the merge queue May 2, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 2, 2023
@viceice viceice added this pull request to the merge queue May 2, 2023
Merged via the queue into main with commit fa36011 May 2, 2023
12 checks passed
@viceice viceice deleted the renovate/glob-10.x branch May 2, 2023 10:24
@renovate-release
Copy link
Collaborator

πŸŽ‰ This PR is included in version 35.69.0 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

mjunker pushed a commit to mjunker/renovate that referenced this pull request May 17, 2023
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants