Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager/dockerfile): support file names that are all lowercase #21877

Merged

Conversation

dotboris
Copy link
Contributor

@dotboris dotboris commented Apr 28, 2023

Changes

I have updated the fileMatch default values for the dockerfile manager so that it now supports Dockerfiles and Containerfiles with all lowercase. This means that renovate should now recognize the following as part of the dockerfile manger.

  • dockerfile
  • something.dockerfile
  • containerfile
  • something.containerfile

Context

In my org, we tend to use component-name.dockerfile for our dockerfiles. I noticed that renovate was not picking those up. If I understand correctly, this is because the dockerfile manager only matches Dockerfile and Containerfile with a capital D or C respectively.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@dotboris dotboris marked this pull request as ready for review May 1, 2023 12:29
rarkins
rarkins previously approved these changes May 2, 2023
@rarkins rarkins added this pull request to the merge queue May 3, 2023
Merged via the queue into renovatebot:main with commit 18ddc2f May 3, 2023
11 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.71.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dotboris dotboris deleted the feat/dockerfile-filematch-lowercase branch May 4, 2023 09:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants