Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: initial implementation of bazel-module manager #21893

Merged
merged 95 commits into from May 20, 2023
Merged

feat: initial implementation of bazel-module manager #21893

merged 95 commits into from May 20, 2023

Conversation

cgrindel
Copy link
Contributor

@cgrindel cgrindel commented Apr 29, 2023 •
edited

Changes

Introduce bazel-module manager.

Context

Related to #13658.
Closes cgrindel/renovate_bzlmod_support#15.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@cgrindel
Initial manager files
5c9822a
@cgrindel
Add placeholder spec file
11ef4b1
@cgrindel
Save work
a8d8374
@cgrindel
Use new datasource name
b1b7c2e
@cgrindel
Have current return undefined instead of null
bfde79f
@cgrindel
Initial parse with type coercion.
d521f72
@cgrindel
Refactor to use processStack
3068800
@cgrindel
Add complex Ctx test
e76e671
@cgrindel
Add lifecycle tests for fragments
d5a59e2
@cgrindel
Add tests for Fragments functions.
a4d3e85
@cgrindel
Test name change
f8c6cf9
@cgrindel
Rename types to stack.
b1cd662
@cgrindel
Add missing test for Stack.
cd61684
@cgrindel
Add missing tests for context
8cf6d5c
@cgrindel
Add isRule to RecordFragment
a0dd10e
@cgrindel
Add instanceExists
818203d
@cgrindel
Add StarlarkBoolean
711b1cd
@cgrindel
Save work. Need to fix extractPackageFile tests
326f293
@cgrindel
Save work.
25c3cd2
@cgrindel
Tests are green
93e30db
@cgrindel
Do not export BazelDepRecord
0edc936
@cgrindel
Refactor extract. Add Fragments.safeAsAttribute.
d0a91f2
@cgrindel
Add schemas for fragments
36b6422
@cgrindel
Change extract to use zod parse/transform to filter output
743a626
@cgrindel
Fix typeError bug
6c04e9b
@cgrindel
Add readme.md
49c2a76
@cgrindel
Add test for invalid string to new BooleanFragment.
4af1143
@cgrindel
Remove TODO.
7908cfc
@cgrindel
Move as functions to their respective class.
024e2a3
@cgrindel
Refactor popStack
f4dcc59
@cgrindel cgrindel requested a review from viceice May 15, 2023 17:03
viceice
viceice reviewed May 15, 2023
View reviewed changes
lib/modules/manager/bazel-module/context.ts Outdated Show resolved Hide resolved
lib/modules/manager/bazel-module/context.ts Outdated Show resolved Hide resolved
lib/modules/manager/bazel-module/context.ts Outdated Show resolved Hide resolved
lib/modules/manager/bazel-module/context.ts Outdated Show resolved Hide resolved
lib/modules/manager/bazel-module/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/bazel-module/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/bazel-module/context.ts Show resolved Hide resolved
@cgrindel cgrindel requested a review from viceice May 15, 2023 22:21
secustor
secustor previously approved these changes May 18, 2023
View reviewed changes
zharinov
zharinov previously approved these changes May 18, 2023
View reviewed changes
lib/modules/manager/bazel-module/fragments.ts Outdated Show resolved Hide resolved
viceice
viceice reviewed May 18, 2023
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small things left. 🤗

lib/modules/manager/bazel-module/parser.ts Outdated Show resolved Hide resolved
lib/modules/manager/bazel-module/parser.ts Outdated Show resolved Hide resolved
lib/modules/manager/bazel-module/parser.ts Outdated Show resolved Hide resolved
lib/modules/manager/bazel-module/parser.ts Outdated Show resolved Hide resolved
lib/modules/manager/bazel-module/parser.ts Outdated Show resolved Hide resolved
lib/modules/manager/bazel-module/parser.ts Outdated Show resolved Hide resolved
@cgrindel cgrindel dismissed stale reviews from zharinov and secustor via f29f956 May 18, 2023 14:15
@cgrindel
Copy link
Contributor Author

@secustor @zharinov Gentle ping for a final review.

@secustor secustor added this pull request to the merge queue May 20, 2023
Merged via the queue into renovatebot:main with commit 7a1d242 May 20, 2023
11 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.97.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@cgrindel cgrindel deleted the feat/13658_bazel_module_manager_new1 branch May 21, 2023 16:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@HonkingGoose HonkingGoose HonkingGoose requested changes

@zharinov zharinov zharinov approved these changes

@viceice viceice viceice approved these changes

@secustor secustor secustor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement bazel-module manager with support for bazel_dep parse and update
6 participants
@cgrindel @renovate-release @zharinov @viceice @secustor @HonkingGoose