Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rubygems): Use schema for fallback API #21933

Merged

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented May 2, 2023

Changes

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov zharinov requested a review from viceice May 2, 2023 18:26
@zharinov
Copy link
Collaborator Author

zharinov commented May 2, 2023

Worked fine locally

@zharinov zharinov requested review from viceice and rarkins May 16, 2023 16:54
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

lib/util/http/index.ts Show resolved Hide resolved
@rarkins rarkins enabled auto-merge May 17, 2023 08:12
@rarkins rarkins added this pull request to the merge queue May 17, 2023
Merged via the queue into renovatebot:main with commit cd5abc8 May 17, 2023
11 checks passed
@rarkins rarkins deleted the refactor/rubygems-fallback-api-schema branch May 17, 2023 08:41
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.90.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants