Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pnpm): extract engine constraint #21959

Merged

Conversation

RahulGautamSingh
Copy link
Collaborator

Changes

  • extract pnpm version from engines field in package.json

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins
Copy link
Collaborator

rarkins commented May 3, 2023

Does it fix the reproduction?

@RahulGautamSingh
Copy link
Collaborator Author

RahulGautamSingh commented May 3, 2023

Does it fix the reproduction?

Reproduction: https://github.com/RahulGautamSingh-testing/renovate-issue-21926
Yes
There is an artifact error but it is a diff one which is caused by my system (I am trying to resolve it)

@RahulGautamSingh RahulGautamSingh marked this pull request as ready for review May 3, 2023 18:00
@rarkins rarkins changed the title fix: extract pnpm engine constraint fix(pnpm): extract engine constraint May 8, 2023
@rarkins rarkins added this pull request to the merge queue May 8, 2023
Merged via the queue into renovatebot:main with commit 6ac9a84 May 8, 2023
11 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.73.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@aaronadamsCA
Copy link
Contributor

aaronadamsCA commented May 10, 2023

Hey, I'm sorry to report this didn't entirely resolve the issue. Here is a fresh reproduction:

https://github.com/nisheretail/renovate-issue-21928-again/pulls

So far I've only succeeding in recreating the issue on the pnpm upgrade branch, however in my repositories I'm seeing the failure on multiple (but not all!) branches.

I can create a new discussion in an hour or so once I've figured out the missing detail in the reproduction.

mjunker pushed a commit to mjunker/renovate that referenced this pull request May 17, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants