Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(onboarding): don’t check onboarding cache unless onboarding=true #21967

Merged
merged 2 commits into from May 4, 2023

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented May 4, 2023

Changes

Only check onboarding cache if onboarding=true

Context

The new onboarding cache interfered with Renovate's ability to disable onboarding and clean up stray PRs

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@secustor
Copy link
Collaborator

secustor commented May 4, 2023

The unit tests are failing

@rarkins rarkins added this pull request to the merge queue May 4, 2023
Merged via the queue into main with commit 665866a May 4, 2023
12 checks passed
@rarkins rarkins deleted the fix/onboarding-cache-disabled branch May 4, 2023 13:23
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.71.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants