feat(npm)!: disable rollbackPrs for npm by default #21970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HonkingGoose
suggested changes
May 4, 2023
HonkingGoose
approved these changes
May 5, 2023
viceice
approved these changes
May 5, 2023
rarkins
added a commit
that referenced
this pull request
May 7, 2023
rarkins
added a commit
that referenced
this pull request
May 10, 2023
rarkins
added a commit
that referenced
this pull request
May 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Disables rollbackPrs by default for npm
Context
I think there's too many false positives here that outweigh the benefits. This means that users can opt-in if they see a need.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: