Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace as with partial/satisfies #21982

Merged
merged 10 commits into from May 8, 2023

Conversation

RahulGautamSingh
Copy link
Collaborator

Changes

  • replace as with satisfies and partial
  • remove unwanted fields from test config objects
  • replace small snapshot file with a toEqual matcher
  • replace ...getConfig() with minimal config in test objects

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@RahulGautamSingh RahulGautamSingh marked this pull request as ready for review May 5, 2023 04:15
@viceice viceice added this pull request to the merge queue May 8, 2023
Merged via the queue into renovatebot:main with commit 0b36f97 May 8, 2023
11 checks passed
@viceice
Copy link
Member

viceice commented May 8, 2023

@RahulGautamSingh Can you concentrate to remove this?

export { getConfig };

It'll help a lot to make tests faster, because we don't need to iterate over each manager and datasource to get the configs. (#21992) I like to make managers lazy loading.

@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.73.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

mjunker pushed a commit to mjunker/renovate that referenced this pull request May 17, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants