Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: switch hcl parser #21988

Merged
merged 2 commits into from May 5, 2023
Merged

build: switch hcl parser #21988

merged 2 commits into from May 5, 2023

Conversation

viceice
Copy link
Member

@viceice viceice commented May 5, 2023

Changes

found an official parser from hashicorp

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

secustor
secustor previously approved these changes May 5, 2023
@secustor secustor enabled auto-merge May 5, 2023 06:27
@secustor
Copy link
Collaborator

secustor commented May 5, 2023

The unit tests are failing.

@viceice
Copy link
Member Author

viceice commented May 5, 2023

reduced fs-extra mocking, because it causes library issues 😕 We should try to avoid mocking fs-extra in general

@secustor secustor added this pull request to the merge queue May 5, 2023
Merged via the queue into main with commit 4924973 May 5, 2023
12 checks passed
@secustor secustor deleted the build/switch-hcl-parser branch May 5, 2023 09:14
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.71.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

mjunker pushed a commit to mjunker/renovate that referenced this pull request May 17, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants