New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: platform=local #22010

Merged

JamieMagee merged 9 commits into main from feat/platform-local

May 10, 2023

Collaborator

rarkins commented May 7, 2023

Changes

Adds the ability to run with --platform=local to run a dry run against the local fs.

Context

Documentation (please check one with an [x])

I have updated the documentation, or
No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

Code inspection only, or
Newly added/modified unit tests, or
No unit tests but ran on a real repository, or
Both unit tests + ran on a real repository


          feat: platform=local

82ee689

rarkins commented

View reviewed changes

lib/config/presets/local/index.ts Show resolved Hide resolved

rarkins commented

View reviewed changes

lib/modules/platform/local/index.ts Show resolved Hide resolved

rarkins commented

View reviewed changes

lib/modules/platform/local/index.ts Show resolved Hide resolved

rarkins commented

View reviewed changes

lib/modules/platform/local/index.ts Show resolved Hide resolved

rarkins commented

View reviewed changes

lib/modules/platform/local/index.ts Show resolved Hide resolved

rarkins commented

View reviewed changes

lib/modules/platform/local/index.ts Show resolved Hide resolved

rarkins commented

View reviewed changes

lib/modules/platform/local/scm.ts Show resolved Hide resolved

rarkins commented

View reviewed changes

lib/modules/platform/local/scm.ts Outdated Show resolved Hide resolved

rarkins commented

View reviewed changes

lib/workers/global/autodiscover.ts Outdated Show resolved Hide resolved

rarkins commented

View reviewed changes

lib/workers/repository/process/index.ts Show resolved Hide resolved

Collaborator Author

rarkins commented May 7, 2023

I can see how a git-aware local could also make sense in some scenarios, perhaps it could be called platform=local-git in future

rarkins requested review from viceice, JamieMagee and secustor

May 7, 2023 06:05

Collaborator Author

rarkins commented May 7, 2023

BTW this is the 3rd or 4th time I've attempted this PR. All preceding attempts were cut short by Renovate proceeding to delete my entire local clone/source unintentionally (localDir..)

Collaborator Author

rarkins commented May 7, 2023 •

edited

The primary use case for this is:

People who want to test their config locally (either for extract or lookup result) without needing to "push to production"
And for whom baseBranches doesn't matter

Does not compare before/after in any way, including branch list. I think that's far beyond an MVP in this case

rarkins mentioned this pull request

Support local git/clone run #3609

Closed


          tests

9c00935

rarkins commented

View reviewed changes

lib/modules/platform/local/index.ts Outdated Show resolved Hide resolved

rarkins commented

View reviewed changes

lib/modules/platform/local/scm.ts Outdated Show resolved Hide resolved

rarkins added 2 commits

May 7, 2023 18:14


          Update lib/modules/platform/local/scm.ts

ee2c625


          coverage

54f6ee6

viceice reviewed

View reviewed changes

lib/modules/platform/local/scm.ts Outdated Show resolved Hide resolved


          Use git for getFileList

95f1dbd

rarkins requested a review from viceice

May 8, 2023 13:23

viceice reviewed

View reviewed changes

Member

viceice left a comment

otherwise LGTM

lib/modules/platform/local/scm.ts Outdated Show resolved Hide resolved

lib/modules/platform/local/scm.ts Show resolved Hide resolved


          add test

11dfe6f

rarkins marked this pull request as ready for review

May 9, 2023 04:50

rarkins requested a review from viceice

May 9, 2023 04:51

viceice reviewed

View reviewed changes

lib/modules/platform/local/scm.ts Outdated Show resolved Hide resolved

rarkins commented

View reviewed changes

lib/modules/platform/local/scm.ts Outdated Show resolved Hide resolved


          Update lib/modules/platform/local/scm.ts

8fc767a

rarkins requested a review from viceice

May 9, 2023 09:18

viceice reviewed

View reviewed changes

Member

viceice left a comment

otherwise LGTM.

lib/modules/platform/local/scm.ts Show resolved Hide resolved

viceice previously approved these changes

View reviewed changes

Member

viceice commented May 9, 2023

needs prettifying

secustor previously approved these changes

View reviewed changes


          Merge branch 'main' into feat/platform-local

c1363f3

JamieMagee previously approved these changes

View reviewed changes


          prettier fix

09cd5a6

JamieMagee dismissed stale reviews from secustor, viceice, and themself via

09cd5a6

May 10, 2023 04:07

JamieMagee enabled auto-merge

May 10, 2023 04:07

JamieMagee approved these changes

View reviewed changes

JamieMagee added this pull request to the merge queue

Merged via the queue into main with commit 93052ec

12 checks passed

JamieMagee deleted the feat/platform-local branch

May 10, 2023 04:52

Collaborator

renovate-release commented May 10, 2023

🎉 This PR is included in version 35.76.0 🎉

The release is available on:

GitHub release
35.76.0

Your semantic-release bot 📦🚀

mjunker pushed a commit to mjunker/renovate that referenced this pull request


          feat: platform=local (renovatebot#22010)

872a032

Co-authored-by: Jamie Magee <jamie.magee@gmail.com>

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.