feat(platform/azure): Recreate Auto-Approve on PR-Update #22028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Heiko Helmle <heiko.helmle@horiba.com>
Signed-off-by: Heiko Helmle <heiko.helmle@horiba.com>
Signed-off-by: Heiko Helmle <heiko.helmle@horiba.com>
Signed-off-by: Heiko Helmle <heiko.helmle@horiba.com>
viceice
reviewed
May 8, 2023
Signed-off-by: Heiko Helmle <heiko.helmle@horiba.com>
viceice
reviewed
May 9, 2023
Signed-off-by: Heiko Helmle <heiko.helmle@horiba.com>
JamieMagee
reviewed
May 9, 2023
Co-authored-by: Jamie Magee <jamie.magee@gmail.com>
JamieMagee
approved these changes
May 10, 2023
|
🎉 This PR is included in version 35.79.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
mjunker
pushed a commit
to mjunker/renovate
that referenced
this pull request
May 17, 2023
…#22028) Signed-off-by: Heiko Helmle <heiko.helmle@horiba.com> Co-authored-by: Jamie Magee <jamie.magee@gmail.com> Co-authored-by: Rhys Arkins <rhys@arkins.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This change will allow renovate to re-approve a PR on azure if autoApprove is enabled. This should solve #15664
This makes autoApprove behavior more intuitive, as updated PRs now have the same constraints as fresh PRs.
Context
See description and discussion in the issue #15664 .
Code (and test) is mostly copied/modified from the corresponding snippet in createPR().
As these are my very first lines of typescript, the code (and especially the test) might be lacking in quality. If that is the case, I'm thankful for pointers.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: