Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(gitlab): add hostType to registry hostRules guide #22055

Merged
merged 1 commit into from May 9, 2023

Conversation

MalteMagnussen
Copy link
Contributor

Fix docs about private GitLab Container Registry config.

Changes

Update Docs about GitLab private registry, so that the example works.

Context

Wasted 4 hours trying to get Renovate to work with a private GitLab registry, and I never once considered that the example might be wrong, before I stumbled on this issue:

If you use env to config host rules, then you need to config like this:

  • DOCKER_GITLAB_EXAMPLE_COM_PASSWORD=renovate-bot
  • DOCKER_GITLAB_EXAMPLE_COM_USERNAME=glpat-xxxxxxxx

And if you use "normal" json config host rules, they need to look like this:

  "hostRules": [
    {
      "hostType": "docker",
      "matchHost": "gitlab.example.com",
      "username": "renovate-bot",
      "password": "glpat-xxxxxxxxxx"
    }
  ],

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Fix docs about private GitLab Container Registry config.
@rarkins rarkins changed the title Update GitLab Docs docs(gitlab): add hostType to registry hostRules guide May 9, 2023
@rarkins rarkins enabled auto-merge May 9, 2023 09:28
@rarkins rarkins added this pull request to the merge queue May 9, 2023
Merged via the queue into renovatebot:main with commit 347c2d0 May 9, 2023
9 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.75.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jullle3
Copy link

jullle3 commented May 13, 2023

@MalteMagnussen 💪

mjunker pushed a commit to mjunker/renovate that referenced this pull request May 17, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants