fix(regex): limit regex manager iterations to 10k to avoid OoM #22084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
secustor
requested changes
May 11, 2023
|
Do we document to anything like that detail today? I'm not sure where to add it where it makes sense |
|
I would put a warning in the regex manager docs. We document limitations as I'm aware. @HonkingGoose Thoughts? |
viceice
previously approved these changes
May 11, 2023
It's not only a regex manager limitation, it's an re2 bug. see my comment on the issue. I would open a bug on re2. |
|
I agree we should open an issue on RE2, but with this PR we are introducing a limitation and this should be documented or at least logged as it is happening. |
|
I'll go with a warn |
secustor
approved these changes
May 11, 2023
HonkingGoose
suggested changes
May 11, 2023
viceice
approved these changes
May 11, 2023
|
🎉 This PR is included in version 35.79.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
mjunker
pushed a commit
to mjunker/renovate
that referenced
this pull request
May 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Limits matchStrings matching to 10k to reduce change of hanging/crashing. The test completes in 16ms for me locally.
Context
Fixes #22083
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: