New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(manager/asdf): support channel suffix on asdf-flutter #22131
Merged
viceice
merged 5 commits into
renovatebot:main
from
ronnnnn:update-support-channel-suffix-on-asdf-flutter
May 17, 2023
Merged
feat(manager/asdf): support channel suffix on asdf-flutter #22131
viceice
merged 5 commits into
renovatebot:main
from
ronnnnn:update-support-channel-suffix-on-asdf-flutter
May 17, 2023
+29
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronnnnn
changed the title
update: support channel suffix on asdf-flutter
feat: support channel suffix on asdf-flutter
May 12, 2023
ronnnnn
changed the title
feat: support channel suffix on asdf-flutter
feat(manager/asdf): support channel suffix on asdf-flutter
May 12, 2023
viceice
reviewed
May 15, 2023
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
viceice
reviewed
May 15, 2023
viceice
reviewed
May 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please test on a real repo
I tested on my repo and worked as I expected. |
viceice
approved these changes
May 17, 2023
🎉 This PR is included in version 35.91.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Support channel suffix on asdf-flutter.
Context
asdf-flutter manages versions of flutter with channel suffix like below.
We can install flutter without channel via asdf-flutter.
However, there is a issue that behavior of installing specific version without channel is unstable.
asdf-community/asdf-flutter#43
Therefore, I want to support upgrading with channel suffix.
Related PR: #20786
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: