Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager/asdf): support channel suffix on asdf-flutter #22131

Merged
merged 5 commits into from May 17, 2023
Merged

feat(manager/asdf): support channel suffix on asdf-flutter #22131

merged 5 commits into from May 17, 2023

Conversation

ronnnnn
Copy link
Contributor

@ronnnnn ronnnnn commented May 12, 2023

Changes

Support channel suffix on asdf-flutter.

Context

asdf-flutter manages versions of flutter with channel suffix like below.

$ asdf list-all flutter
...
3.7.12-stable
3.10.0-1.4.pre-beta
3.10.0-1.5.pre-beta
3.10.0-stable
3.11.0-0.0.pre-beta

We can install flutter without channel via asdf-flutter.
However, there is a issue that behavior of installing specific version without channel is unstable.
asdf-community/asdf-flutter#43

Therefore, I want to support upgrading with channel suffix.

Related PR: #20786

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@ronnnnn ronnnnn changed the title update: support channel suffix on asdf-flutter feat: support channel suffix on asdf-flutter May 12, 2023
@ronnnnn ronnnnn changed the title feat: support channel suffix on asdf-flutter feat(manager/asdf): support channel suffix on asdf-flutter May 12, 2023
ronnnnn and others added 2 commits May 15, 2023 17:31
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@ronnnnn ronnnnn requested a review from viceice May 15, 2023 09:29
@ronnnnn ronnnnn requested a review from viceice May 15, 2023 12:20
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please test on a real repo

@ronnnnn
Copy link
Contributor Author

ronnnnn commented May 16, 2023

I tested on my repo and worked as I expected.

@ronnnnn ronnnnn requested a review from viceice May 16, 2023 01:39
@viceice viceice added this pull request to the merge queue May 17, 2023
Merged via the queue into renovatebot:main with commit 5207da4 May 17, 2023
11 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.91.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ronnnnn ronnnnn deleted the update-support-channel-suffix-on-asdf-flutter branch May 18, 2023 05:16
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants