Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bitbucket): add paginate http option #22135

Merged
merged 3 commits into from May 13, 2023
Merged

feat(bitbucket): add paginate http option #22135

merged 3 commits into from May 13, 2023

Conversation

setchy
Copy link
Collaborator

@setchy setchy commented May 12, 2023 •
edited

Changes

Adds paginate http options support for bitbucket client

Context

Split out from #22094

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@setchy
Copy link
Collaborator Author

setchy commented May 12, 2023 •
edited

Unit tests will fast follow once I get feedback on the functional code.

@setchy setchy added the platform:bitbucket Bitbucket Cloud platform label May 12, 2023
@setchy setchy mentioned this pull request May 12, 2023
Merged
6 tasks
@setchy setchy requested a review from viceice May 12, 2023 15:27
viceice
viceice reviewed May 12, 2023
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs coverage, otherwise LGTM

@setchy setchy requested a review from viceice May 12, 2023 17:17
@rarkins rarkins added this pull request to the merge queue May 13, 2023
Merged via the queue into renovatebot:main with commit 976a5a1 May 13, 2023
11 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.81.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@setchy setchy mentioned this pull request May 13, 2023
Merged
6 tasks
@setchy setchy added the type:feature Feature (new functionality) label May 13, 2023
@setchy setchy deleted the feature/bitbucket-paginate-http branch May 13, 2023 16:02
mjunker pushed a commit to mjunker/renovate that referenced this pull request May 17, 2023
@setchy @mjunker
feat(bitbucket): add paginate http option (renovatebot#22135)
2069bc1
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
platform:bitbucket Bitbucket Cloud platform type:feature Feature (new functionality)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@setchy @renovate-release @viceice @rarkins