fix(gitlab): ignoreApprovals add check for existingAnyApproverRule #22237
+76
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrondina
changed the title
rarkins
previously approved these changes
May 15, 2023
viceice
previously requested changes
May 15, 2023
|
@fredrondina Thanks for doing this. These changes look good |
a1flecke
approved these changes
May 16, 2023
rarkins
approved these changes
May 16, 2023
|
🎉 This PR is included in version 35.87.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Update gitlab ignoreApprovals option to not break if there is an existing rule of type 'any_approver'
Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: