New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update json-schema #22262
fix: update json-schema #22262
Conversation
1054a1055,1058
> "description": {
> "type": "string",
> "description": "A custom description"
> },
1553a1558,1561
> "description": {
> "type": "string",
> "description": "A custom description"
> },
2069a2078,2081
> "description": {
> "type": "string",
> "description": "A custom description"
> },
2329a2342,2345
> "description": {
> "type": "string",
> "description": "A custom description"
> },
2748,2784c2764,2808
< "enum": [
< "aws-machine-image",
< "azure-rest-api",
< "bazel-module",
< "cargo",
< "composer",
< "conan",
< "deb",
< "debian",
< "docker",
< "git",
< "go-mod-directive",
< "gradle",
< "hashicorp",
< "helm",
< "hermit",
< "hex",
< "ivy",
< "kubernetes-api",
< "loose",
< "maven",
< "nixpkgs",
< "node",
< "npm",
< "nuget",
< "pep440",
< "perl",
< "poetry",
< "python",
< "redhat",
< "regex",
< "rez",
< "ruby",
< "semver",
< "semver-coerced",
< "swift",
< "ubuntu"
---
> "oneOf": [
> {
> "enum": [
> "aws-machine-image",
> "azure-rest-api",
> "bazel-module",
> "cargo",
> "composer",
> "conan",
> "deb",
> "debian",
> "docker",
> "git",
> "go-mod-directive",
> "gradle",
> "hashicorp",
> "helm",
> "hermit",
> "hex",
> "ivy",
> "kubernetes-api",
> "loose",
> "maven",
> "nixpkgs",
> "node",
> "npm",
> "nuget",
> "pep440",
> "perl",
> "poetry",
> "python",
> "redhat",
> "regex",
> "rez",
> "ruby",
> "semver",
> "semver-coerced",
> "swift",
> "ubuntu"
> ]
> },
> {
> "type": "string",
> "pattern": "^regex:"
> } |
@viceice I don't understand this "a custom description" change. Here's an example: "hostRules": {
"description": "Host rules/configuration including credentials.",
"type": "array",
"items": {
"allOf": [
{
"type": "object",
"properties": {
"description": {
"type": "string",
"description": "A custom description"
},
"abortIgnoreStatusCodes": {
"description": "A list of HTTP status codes safe to ignore even when `abortOnError=true`.",
"type": "array",
"items": {
"type": "number"
}
}, |
it adds the description field to the schema, which we already heavily use to describe package rules. so the editor can suggest that field now. |
i can change the description of the description property, it seems to confusing 😬 |
|
🎉 This PR is included in version 35.90.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes
^regex:.*
asversioning
packageRules
orregexManagers
)Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: