Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bitbucket): add support for pagelen #22278

Merged
merged 8 commits into from May 20, 2023
Merged

feat(bitbucket): add support for pagelen #22278

merged 8 commits into from May 20, 2023

Conversation

setchy
Copy link
Collaborator

@setchy setchy commented May 17, 2023 •
edited

Changes

  • Add support for optional paglen
  • Add max pagelen if non provided and requesting paginated data
  • Update pagination logic to use next url as-is previous response

Context

Pre-req for #22272

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@setchy setchy added type:feature Feature (new functionality) platform:bitbucket Bitbucket Cloud platform labels May 17, 2023
@setchy setchy mentioned this pull request May 17, 2023
Merged
6 tasks
viceice
viceice reviewed May 17, 2023
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing code coverage

@setchy setchy requested a review from viceice May 17, 2023 11:31
@setchy
Copy link
Collaborator Author

setchy commented May 17, 2023

missing code coverage

🙈 - oops. all good now :)

viceice
viceice reviewed May 17, 2023
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

lib/util/http/bitbucket.ts Outdated Show resolved Hide resolved
@setchy setchy requested a review from viceice May 17, 2023 18:26
viceice
viceice reviewed May 17, 2023
View reviewed changes
lib/util/http/bitbucket.ts Outdated Show resolved Hide resolved
@setchy setchy requested a review from viceice May 17, 2023 18:38
rarkins
rarkins previously approved these changes May 18, 2023
View reviewed changes
viceice
viceice reviewed May 18, 2023
View reviewed changes
lib/util/http/bitbucket.ts Outdated Show resolved Hide resolved
@setchy setchy requested review from viceice and rarkins May 18, 2023 12:08
@viceice viceice requested a review from secustor May 18, 2023 12:23
@setchy
Copy link
Collaborator Author

setchy commented May 19, 2023

@rarkins - apologies, your approval got clearer. 🙏

@rarkins rarkins added this pull request to the merge queue May 20, 2023
Merged via the queue into renovatebot:main with commit 06f7134 May 20, 2023
11 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.97.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@setchy setchy deleted the feature/bitbucket-pagelen-opts branch May 20, 2023 13:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@secustor secustor secustor approved these changes

@rarkins rarkins Awaiting requested review from rarkins

Assignees
No one assigned
Labels
platform:bitbucket Bitbucket Cloud platform type:feature Feature (new functionality)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@setchy @renovate-release @viceice @rarkins @secustor