Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manager/nuget): return null for no deps #22282

Merged
merged 1 commit into from May 17, 2023

Conversation

viceice
Copy link
Member

@viceice viceice commented May 17, 2023

Changes

Align with other manager, which returns null if no deps are found in file.
I found a lot empty sections on my dependency dashboard.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins
Copy link
Collaborator

rarkins commented May 17, 2023

This PR makes sense now, but later it may make more sense for managers to return package files with no deps in order for it to be more transparent/obvious to the user - we need to work out when to suppress them, e.g. in dashboard

@viceice
Copy link
Member Author

viceice commented May 17, 2023

This PR makes sense now, but later it may make more sense for managers to return package files with no deps in order for it to be more transparent/obvious to the user - we need to work out when to suppress them, e.g. in dashboard

Currently it makes viewing logs hard when searching for problems, because i've hundreds of matching files for nuget, but only a few with real dependencies. The others are simply support files and it would be hard to filter them accordingly.

@viceice viceice added this pull request to the merge queue May 17, 2023
Merged via the queue into main with commit 9a87c3f May 17, 2023
12 checks passed
@viceice viceice deleted the fix/nuget/return-null-no-deps branch May 17, 2023 08:50
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.90.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants