Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(maven): Implement latest fix of the Maven versions #22288

Merged
merged 2 commits into from May 17, 2023

Conversation

zharinov
Copy link
Collaborator

Changes

  • Adjust our implementation to the latest changes in the maven-artifact package
  • Port the original unit test

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov
Copy link
Collaborator Author

Before:

$ java -jar maven-artifact-3.8.6.jar 1.x 1-x
Display parameters as parsed by Maven (in canonical form and as a list of tokens) and comparison result:
1. 1.x -> 1.x; tokens: [1, x]
   1.x < 1-x
2. 1-x -> 1-x; tokens: [1, [x]]

After:

java -jar maven-artifact-3.8.7.jar 1.x 1-x
Display parameters as parsed by Maven (in canonical form and as a list of tokens) and comparison result:
1. 1.x -> 1-x; tokens: [1, [x]]
   1.x == 1-x
2. 1-x -> 1-x; tokens: [1, [x]]

@zharinov zharinov requested review from rarkins and viceice May 17, 2023 14:02
viceice
viceice previously approved these changes May 17, 2023
@rarkins rarkins enabled auto-merge May 17, 2023 14:47
@rarkins rarkins added this pull request to the merge queue May 17, 2023
Merged via the queue into renovatebot:main with commit 42e2b27 May 17, 2023
11 checks passed
@rarkins rarkins deleted the fix/maven-versioning-mng-7644 branch May 17, 2023 15:20
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.91.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants