Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager/flux): Support OCI Helm repositories #22291

Merged
merged 15 commits into from May 25, 2023

Conversation

samip5
Copy link
Contributor

@samip5 samip5 commented May 17, 2023

Changes

Update flux manager's code to support OCI Helm repositories.

Context

Documentation

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@samip5 samip5 changed the title feat(flux): Support OCI Helm repositories feat(manager/flux): Support OCI Helm repositories May 17, 2023
lib/modules/manager/flux/__fixtures__/helmOCIRelease.yaml Outdated Show resolved Hide resolved
lib/modules/manager/flux/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/flux/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/flux/extract.ts Outdated Show resolved Hide resolved
@samip5 samip5 requested a review from viceice May 19, 2023 14:04
@samip5
Copy link
Contributor Author

samip5 commented May 19, 2023

I'm not sure what's wrong with the tests in the build as all of them seem to pass but yet it fails with exit code 1?

@samip5 samip5 requested a review from viceice May 19, 2023 17:31
lib/modules/manager/flux/types.ts Outdated Show resolved Hide resolved
lib/modules/manager/flux/extract.ts Show resolved Hide resolved
@samip5 samip5 requested a review from viceice May 19, 2023 18:34
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@samip5 samip5 requested a review from viceice May 22, 2023 00:35
buroa
buroa previously approved these changes May 22, 2023
@onedr0p
Copy link
Contributor

onedr0p commented May 23, 2023

@viceice how's this looking now? /lgtm?

@0dragosh
Copy link

@viceice A number of us have been waiting on this issue for quite a while, it would be great if this got merged.

@samip5
Copy link
Contributor Author

samip5 commented May 25, 2023

@viceice Please take a look again. :)

@viceice
Copy link
Member

viceice commented May 25, 2023

@viceice Please take a look again. :)

Please avoid such comments and use the re-request review function only and be patient.

@viceice viceice added this pull request to the merge queue May 25, 2023
@samip5
Copy link
Contributor Author

samip5 commented May 25, 2023

Please avoid such comments and use the re-request review function only and be patient.

Sorry about that, will do in the future.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 25, 2023
@samip5
Copy link
Contributor Author

samip5 commented May 25, 2023

It seems that windows tests failing results in the whole thing failing.

@viceice viceice added the ci:fulltest Run full test suite on all platforms label May 25, 2023
@rarkins rarkins added this pull request to the merge queue May 25, 2023
Merged via the queue into renovatebot:main with commit e066924 May 25, 2023
13 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.102.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@samip5 samip5 deleted the feat/flux-helmrepo-oci branch May 25, 2023 22:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ci:fulltest Run full test suite on all platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flux: Support updating OCI helm charts
7 participants