Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config-error): raise a warning issue for misconfigured matchConfidence #22296

Merged
merged 7 commits into from May 18, 2023
Merged

feat(config-error): raise a warning issue for misconfigured matchConfidence #22296

merged 7 commits into from May 18, 2023

Conversation

Gabriel-Ladzaretti
Copy link
Collaborator

@Gabriel-Ladzaretti Gabriel-Ladzaretti commented May 18, 2023 •
edited

Changes

Raise a new warning issue whenever the matchConfidence PackageRules matcher is used without credentials.

Tested both for onboarding and onboarded repos.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@Gabriel-Ladzaretti Gabriel-Ladzaretti marked this pull request as ready for review May 18, 2023 10:09
@Gabriel-Ladzaretti Gabriel-Ladzaretti changed the title feat(config-error): raise error for misconfigured matchConfidence feat(config-error): raise a warning issue for misconfigured matchConfidence May 18, 2023
HonkingGoose
HonkingGoose suggested changes May 18, 2023
View reviewed changes
lib/constants/error-messages.ts Outdated Show resolved Hide resolved
viceice
viceice reviewed May 18, 2023
View reviewed changes
lib/util/merge-confidence/index.ts Outdated Show resolved Hide resolved
lib/util/package-rules/merge-confidence.ts Outdated Show resolved Hide resolved
lib/workers/repository/finalize/index.ts Show resolved Hide resolved
Gabriel-Ladzaretti and others added 4 commits May 18, 2023 13:40
@Gabriel-Ladzaretti @HonkingGoose
Update lib/constants/error-messages.ts
8107042 
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@Gabriel-Ladzaretti
minimize diff
b060d35
@Gabriel-Ladzaretti
Merge remote-tracking branch 'origin/feat/raise-credentials-issue' in…
dd00e91 
…to feat/raise-credentials-issue
@Gabriel-Ladzaretti
update issue styling
2eb2145
@rarkins rarkins added this pull request to the merge queue May 18, 2023
Merged via the queue into renovatebot:main with commit d88d63b May 18, 2023
11 checks passed
@rarkins rarkins deleted the feat/raise-credentials-issue branch May 18, 2023 17:25
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.96.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@HonkingGoose HonkingGoose HonkingGoose approved these changes

@rarkins rarkins Awaiting requested review from rarkins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Gabriel-Ladzaretti @renovate-release @viceice @rarkins @HonkingGoose