Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(http): Rename useCache option to memCache #22300

Merged
merged 3 commits into from May 18, 2023

Conversation

zharinov
Copy link
Collaborator

Changes

I want to implement etagCache option, but for now I want to make it clear that another cache-related option is responsible for client-side memory-located cache

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov zharinov requested review from viceice and rarkins May 18, 2023 13:41
viceice
viceice previously approved these changes May 18, 2023
@viceice viceice enabled auto-merge May 18, 2023 13:47
auto-merge was automatically disabled May 18, 2023 13:57

Head branch was pushed to by a user without write access

@zharinov zharinov requested a review from viceice May 18, 2023 13:58
@zharinov
Copy link
Collaborator Author

Sorry, just added an optimization that calculates cache key only when it's needed

@rarkins rarkins added this pull request to the merge queue May 18, 2023
Merged via the queue into renovatebot:main with commit 8cdd1a2 May 18, 2023
11 checks passed
@rarkins rarkins deleted the refactor/http-mem-cache branch May 18, 2023 15:03
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.96.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

NiasSt90 added a commit to intentus-GmbH/renovate that referenced this pull request Jun 15, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants