Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rubygems): Extract copystring function to the utils #22322

Merged
merged 2 commits into from May 20, 2023

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented May 20, 2023

Changes

  • Extract function to the util/string.ts
  • Simplify code by using only slower type of string memory allocation for copy.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov zharinov changed the title refactor(rubygems): Simplify copystr implementation refactor(rubygems): Extract copystring function to the utils May 20, 2023
@zharinov zharinov requested review from viceice and rarkins May 20, 2023 10:44
@rarkins rarkins added this pull request to the merge queue May 20, 2023
Merged via the queue into renovatebot:main with commit 86735d7 May 20, 2023
11 checks passed
@rarkins rarkins deleted the refactor/rubygems-simplify-copystr branch May 20, 2023 12:36
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.97.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants