Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine matchFiles and matchPaths #22395

Closed
rarkins opened this issue May 24, 2023 · 6 comments
Closed

Combine matchFiles and matchPaths #22395

rarkins opened this issue May 24, 2023 · 6 comments
Assignees
@rarkins
Labels
breaking Breaking change, requires major version bump priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:in-progress Someone is working on implementation type:refactor Refactoring or improving of existing code v36

Comments

@rarkins
Copy link
Collaborator

rarkins commented May 24, 2023

Describe the proposed change(s).

Once partial string matching is removed from matchPaths (see #22394) we should combine matchFiles and matchPaths into one - probably in v36 too. It seems that a plain file name like matchFiles uses is a valid glob anyway, so the only difference is that matchFiles matches against both package file and lock file while matchPaths currently matches only against package files.

We could either combine them into matchPaths, or we could make a new field like matchFileNames.
@rarkins rarkins added priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:refactor Refactoring or improving of existing code status:requirements Full requirements are not yet known, so implementation should not be started labels May 24, 2023
@zharinov zharinov self-assigned this May 24, 2023
@viceice

This comment was marked as outdated.

Sign in to view
@rarkins
Copy link
Collaborator Author

rarkins commented May 24, 2023

Glob should not. It was our custom partial string matching which caused that, to be removed in v36

@rarkins
Copy link
Collaborator Author

rarkins commented May 24, 2023

image

Tested at https://www.digitalocean.com/community/tools/glob?comments=true&glob=package.json&matches=false&tests=package.json&tests=backend%2Fpackage.json

@rarkins
Copy link
Collaborator Author

rarkins commented May 24, 2023

The main problem in merging these is that if someone used both (which would be a bad idea..) then now they will be "or" and not "and". So best to do it in v36 too

@rarkins
Copy link
Collaborator Author

rarkins commented May 24, 2023

Conclusion:

  • Migrate both to matchFileNames
  • If both were defined then merge them

@rarkins rarkins added the breaking Breaking change, requires major version bump label May 24, 2023
@rarkins rarkins assigned rarkins and unassigned zharinov May 24, 2023
@rarkins rarkins added status:in-progress Someone is working on implementation and removed status:requirements Full requirements are not yet known, so implementation should not be started labels May 24, 2023
rarkins added a commit that referenced this issue May 24, 2023
@rarkins
feat(package-rules)!: merge matchPaths and matchFiles into matchFileN…
0d0649a 
…ames

Closes #22395

BREAKING CHANGE: matchPaths and matchFiles are now combined and merged into matchFileNames
rarkins added a commit that referenced this issue May 24, 2023
@rarkins
feat(package-rules)!: merge matchPaths and matchFiles into matchFileN…
d639110 
…ames

Closes #22395

BREAKING CHANGE: matchPaths and matchFiles are now combined and merged into matchFileNames
@rarkins rarkins mentioned this issue May 24, 2023
Merged
6 tasks
@rarkins rarkins added the v36 label Jun 12, 2023
rarkins added a commit that referenced this issue Jul 4, 2023
@rarkins
feat!: merge matchPaths and matchFiles into matchFileNames (#22406)
3de23a1 
Closes #22395

BREAKING CHANGE: matchPaths and matchFiles are now combined into matchFileNames, supporting exact match and glob-only
@rarkins rarkins closed this as completed in e3d5f7d Jul 4, 2023
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 36.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

SlashNephy added a commit to SlashNephy/infrastructure that referenced this issue Jul 6, 2023
@SlashNephy
Update renovate.json
d7012d3 
temporary fix until renovatebot/renovate#22395 release

Signed-off-by: SlashNephy <spica@starry.blue>
@github-actions github-actions bot mentioned this issue Jul 9, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rarkins rarkins

Labels
breaking Breaking change, requires major version bump priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:in-progress Someone is working on implementation type:refactor Refactoring or improving of existing code v36
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@zharinov @viceice @rarkins @renovate-release