Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manager): unify logging #22398

Merged
merged 5 commits into from May 25, 2023
Merged

fix(manager): unify logging #22398

merged 5 commits into from May 25, 2023

Conversation

viceice
Copy link
Member

@viceice viceice commented May 24, 2023

Changes

Unify parser error logging for allmost all managers.

  • log packageFile on errors
  • rename fileName to packageFile
  • reduce warning to debug (was inconsistent before), maybe we should change all to warn, so users are more aware of parsing issues?

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice requested review from rarkins and secustor May 24, 2023 08:23
@viceice viceice requested a review from JamieMagee as a code owner May 24, 2023 08:23
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the optional packageFile? params due to tests?

lib/modules/manager/buildkite/extract.ts Show resolved Hide resolved
lib/modules/manager/bundler/extract.ts Show resolved Hide resolved
lib/modules/manager/ansible-galaxy/extract.ts Show resolved Hide resolved
lib/modules/manager/bundler/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/pipenv/extract.ts Outdated Show resolved Hide resolved
viceice and others added 2 commits May 24, 2023 23:27
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
@viceice
Copy link
Member Author

viceice commented May 24, 2023

fixing the optional package file would cause the PR to become at least four times more changes and double of changed files.

so I would prefer to do those changes in follow up PR's.

also lifting the trace call at beginning of the extract is a good idea for a separate PR.

@viceice viceice requested review from rarkins and secustor May 25, 2023 10:05
@rarkins rarkins enabled auto-merge May 25, 2023 16:52
@rarkins rarkins added this pull request to the merge queue May 25, 2023
Merged via the queue into main with commit 497d4c1 May 25, 2023
11 checks passed
@rarkins rarkins deleted the fix/unify-manager-logging branch May 25, 2023 17:21
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.102.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[helm-values manager]: YAMLException not showing what file the issue is occuring with
4 participants