Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager/terraform): search lockfile on parent dirs #22403

Merged
merged 3 commits into from May 25, 2023

Conversation

viceice
Copy link
Member

@viceice viceice commented May 24, 2023

Changes

  • search for lockfile in silbling and parent dirs

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice requested review from rarkins and secustor May 24, 2023 09:55
Copy link
Collaborator

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔
Not sure what would happen with different ranges in the modules.
From top of my head the code will simply pick the first range for the constraint field in the lock file.

Also If I'm not mistaken should there be multiple modules with the same provider, with different versions/ranges and are not group then change will be flapping.

wiebeck
wiebeck previously approved these changes May 24, 2023
@viceice
Copy link
Member Author

viceice commented May 25, 2023

🤔 Not sure what would happen with different ranges in the modules. From top of my head the code will simply pick the first range for the constraint field in the lock file.

Also If I'm not mistaken should there be multiple modules with the same provider, with different versions/ranges and are not group then change will be flapping.

We can improve that later, for now we should expect users to enforce consistent version declarations.

@rarkins rarkins added this pull request to the merge queue May 25, 2023
Merged via the queue into main with commit a8c8c00 May 25, 2023
11 checks passed
@rarkins rarkins deleted the feat/terraform/search-lockfile-on-parent-dirs branch May 25, 2023 13:11
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.101.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants