Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Merged multiple skipReasons into unspecified-version. #22409

Merged
merged 4 commits into from May 25, 2023

Conversation

ryo-manba
Copy link
Contributor

@ryo-manba ryo-manba commented May 24, 2023

Changes

Replaced any-version, no-version, and unknown-version skipReason with unspecified-version.

Context

Closes #22199

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@CLAassistant
Copy link

CLAassistant commented May 24, 2023

CLA assistant check
All committers have signed the CLA.

@ryo-manba ryo-manba changed the title refactor: merge skipReasons refactor: Replace 'any-version' and 'no-version' with 'unspecified-version' May 24, 2023
lib/types/skip-reason.ts Outdated Show resolved Hide resolved
@ryo-manba ryo-manba requested a review from secustor May 24, 2023 13:17
secustor
secustor previously approved these changes May 24, 2023
Copy link
Collaborator

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should also replace unknown-version

lib/types/skip-reason.ts Outdated Show resolved Hide resolved
@ryo-manba ryo-manba changed the title refactor: Replace 'any-version' and 'no-version' with 'unspecified-version' refactor: Merged multiple skipReasons into unspecified-version. May 24, 2023
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@secustor @rarkins should we leave unknown version for unsupprted values? or better unsupported-version 🤔

lib/modules/manager/npm/extract/index.spec.ts Show resolved Hide resolved
lib/modules/manager/pipenv/extract.ts Show resolved Hide resolved
@secustor
Copy link
Collaborator

I find unspecified-version good enough.

@ryo-manba ryo-manba requested a review from rarkins May 24, 2023 22:54
@rarkins rarkins enabled auto-merge May 25, 2023 04:48
@rarkins rarkins added this pull request to the merge queue May 25, 2023
Merged via the queue into renovatebot:main with commit 0417c11 May 25, 2023
9 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.101.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2023
@ryo-manba ryo-manba deleted the refactor/merge-skip-reasons branch January 20, 2024 13:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: Merge any-version and no-version skipReasons
6 participants