feat(package-rules)!: match packageName for matchPackageNames #22703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
gitAuthor discover for GitLab now prefers the field `commit_email` over `email`. BREAKING CHANGE: GitLab gitAuthor will change from the account's "email" to "commit_email" if they are different.
Set `{ dot: true }` for minimatch.
BREAKING CHANGE: dot files will now be included by default for all minimatch results
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
gitAuthor discover for GitLab now prefers the field `commit_email` over `email`. BREAKING CHANGE: GitLab gitAuthor will change from the account's "email" to "commit_email" if they are different.
Set `{ dot: true }` for minimatch.
BREAKING CHANGE: dot files will now be included by default for all minimatch results
Co-authored-by: Rhys Arkins <rhys@arkins.net> Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
This reverts commit 4c68647.
Changes fetchReleaseNotes from boolean to enum, with values off, branch, pr. Closes #20476 BREAKING CHANGE: Release notes won't be fetched early for commitBody insertion unless explicitly configured with fetchReleaseNotes=branch
# Conflicts: # lib/modules/platform/gitea/index.md
rarkins
force-pushed
the
feat/20926-match-package-names
branch
from
78e9b8a
to
553d2bc
Compare
rarkins
force-pushed
the
v36
branch
2 times, most recently
from
a759d49
to
f0ca46e
Compare
viceice
reviewed
Jun 18, 2023
viceice
approved these changes
Jun 24, 2023
rarkins
added a commit
that referenced
this pull request
Jun 27, 2023
rarkins
added a commit
that referenced
this pull request
Jun 27, 2023
rarkins
added a commit
that referenced
this pull request
Jul 1, 2023
rarkins
added a commit
that referenced
this pull request
Jul 4, 2023
rarkins
added a commit
that referenced
this pull request
Jul 4, 2023
rarkins
added a commit
that referenced
this pull request
Jul 4, 2023
Closes #20926 BREAKING CHANGE: matchPackageNames now matches both depName (existing) and packageName (new)
rarkins
added a commit
that referenced
this pull request
Jul 4, 2023
Closes #20926 BREAKING CHANGE: matchPackageNames now matches both depName (existing) and packageName (new)
rarkins
added a commit
that referenced
this pull request
Jul 4, 2023
Closes #20926 BREAKING CHANGE: matchPackageNames now matches both depName (existing) and packageName (new)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Now matches against packageName for matchPackageNames, and warns if the fallback depName is used.
Context
Closes #20926
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: