Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: replace dockerImagePrefix with dockerSidecarImage #22708

Merged
merged 18 commits into from
Jun 17, 2023
Merged

feat!: replace dockerImagePrefix with dockerSidecarImage #22708

merged 18 commits into from
Jun 17, 2023

Conversation

RahulGautamSingh
Copy link
Collaborator

Changes

  • replace dockerImagePrefix with sidecarImage

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

rarkins
rarkins requested changes Jun 12, 2023
View reviewed changes
docs/usage/self-hosted-configuration.md Outdated Show resolved Hide resolved
docs/usage/self-hosted-configuration.md Outdated Show resolved Hide resolved
docs/usage/self-hosted-configuration.md Outdated Show resolved Hide resolved
lib/config/options/index.ts Outdated Show resolved Hide resolved
lib/util/exec/docker/index.ts Outdated Show resolved Hide resolved
@RahulGautamSingh RahulGautamSingh changed the title feat: replace dockerImagePrefix with sidecarImage feat!: replace dockerImagePrefix with sidecarImage Jun 12, 2023
@rarkins rarkins changed the title feat!: replace dockerImagePrefix with sidecarImage feat!: replace dockerImagePrefix with dockerSidecarImage Jun 12, 2023
viceice
viceice reviewed Jun 12, 2023
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs migration, so old prefix gets joined with sidecar and assigned to new option to not break existing users.

docs/usage/self-hosted-configuration.md Outdated Show resolved Hide resolved
lib/util/exec/index.spec.ts Outdated Show resolved Hide resolved
renovate.json Outdated Show resolved Hide resolved
RahulGautamSingh and others added 2 commits June 13, 2023 00:07
@RahulGautamSingh
update regex manager
ebb8d7e
@RahulGautamSingh @viceice
Apply suggestions from code review
7690613 
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@RahulGautamSingh
Copy link
Collaborator Author

needs migration, so old prefix gets joined with sidecar and assigned to new option to not break existing users.

Thought the breaking is intentional as mentioned here:

No need to migrate - we should declare it as a breaking change.
#21217 (comment)

@rarkins
Copy link
Collaborator

rarkins commented Jun 12, 2023

@viceice let's just make this one breaking? It only applies to self-hosted users

@viceice
Copy link
Member

viceice commented Jun 12, 2023

so no migration? should be pretty straight. 🤔

@RahulGautamSingh RahulGautamSingh marked this pull request as ready for review June 14, 2023 00:16
@rarkins rarkins changed the base branch from main to v36 June 15, 2023 16:59
@rarkins rarkins merged commit d691aac into renovatebot:v36 Jun 17, 2023
31 checks passed
rarkins added a commit that referenced this pull request Jun 18, 2023
@RahulGautamSingh @rarkins @viceice
feat!: replace dockerImagePrefix with dockerSidecarImage (#22708)
1eb2533 
Co-authored-by: Rhys Arkins <rhys@arkins.net>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
rarkins added a commit that referenced this pull request Jun 18, 2023
@RahulGautamSingh @rarkins @viceice
feat!: replace dockerImagePrefix with dockerSidecarImage (#22708)
09e5df7 
Co-authored-by: Rhys Arkins <rhys@arkins.net>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
rarkins added a commit that referenced this pull request Jun 18, 2023
@RahulGautamSingh @rarkins @viceice
feat!: replace dockerImagePrefix with dockerSidecarImage (#22708)
941ca05 
Co-authored-by: Rhys Arkins <rhys@arkins.net>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
rarkins added a commit that referenced this pull request Jun 27, 2023
@RahulGautamSingh @rarkins @viceice
feat!: replace dockerImagePrefix with dockerSidecarImage (#22708)
ddd2af9 
Co-authored-by: Rhys Arkins <rhys@arkins.net>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@rarkins rarkins mentioned this pull request Jun 27, 2023
Closed
28 tasks
rarkins added a commit that referenced this pull request Jun 27, 2023
@RahulGautamSingh @rarkins @viceice
feat!: replace dockerImagePrefix with dockerSidecarImage (#22708)
6b0bd7e 
Co-authored-by: Rhys Arkins <rhys@arkins.net>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
rarkins added a commit that referenced this pull request Jul 1, 2023
@RahulGautamSingh @rarkins @viceice
feat!: replace dockerImagePrefix with dockerSidecarImage (#22708)
4b76705 
Co-authored-by: Rhys Arkins <rhys@arkins.net>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
rarkins added a commit that referenced this pull request Jul 4, 2023
@RahulGautamSingh @rarkins @viceice
feat!: replace dockerImagePrefix with dockerSidecarImage (#22708)
74213ef 
Co-authored-by: Rhys Arkins <rhys@arkins.net>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
rarkins added a commit that referenced this pull request Jul 4, 2023
@RahulGautamSingh @rarkins @viceice
feat!: replace dockerImagePrefix with dockerSidecarImage (#22708)
f28dd53 
Co-authored-by: Rhys Arkins <rhys@arkins.net>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
rarkins pushed a commit that referenced this pull request Jul 4, 2023
@RahulGautamSingh @rarkins
feat!: replace dockerImagePrefix with dockerSidecarImage (#22708)
eaef48a 
Closes #21217

BREAKING CHANGE: dockerImagePrefix is now replaced by dockerSidecarImage
rarkins pushed a commit that referenced this pull request Jul 4, 2023
@RahulGautamSingh @rarkins
feat!: replace dockerImagePrefix with dockerSidecarImage (#22708)
86b8d83 
Closes #21217

BREAKING CHANGE: dockerImagePrefix is now replaced by dockerSidecarImage
rarkins pushed a commit that referenced this pull request Jul 4, 2023
@RahulGautamSingh @rarkins
feat!: replace dockerImagePrefix with dockerSidecarImage (#22708)
aa14b77 
Closes #21217

BREAKING CHANGE: dockerImagePrefix is now replaced by dockerSidecarImage
@github-actions github-actions bot mentioned this pull request Jul 9, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@rarkins rarkins rarkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace dockerImagePrefix with configurable sidecar image
3 participants
@RahulGautamSingh @rarkins @viceice