Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): Making suppression notification work for PR and onboardingPR for consistency #22831

Conversation

MojoJojo86
Copy link
Contributor

Context

New feature released two days ago to allow suppression Notification flag for dependencyLookupWarnings.
Worked fine for the use case of the dependency dashboard but noticed inconsistency of the warning still showing in PR's and onboarding PR's so this just applies it across all now.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@MojoJojo86 MojoJojo86 changed the title Flag rename and missed instance of it in test causing code coverage f… Refactor(config): Flag rename and missed instance of it in test causing code coverage f… Jun 16, 2023
@MojoJojo86 MojoJojo86 changed the title Refactor(config): Flag rename and missed instance of it in test causing code coverage f… refactor(config): Flag rename and missed instance of it in test causing code coverage f… Jun 16, 2023
…tion_work_for_PR_and_onboardPR_for_consistency
@MojoJojo86 MojoJojo86 changed the title refactor(config): Flag rename and missed instance of it in test causing code coverage f… refactor(config): Making suppression notification work for PR and onboardingPR for consistency Jun 16, 2023
@MojoJojo86 MojoJojo86 requested a review from viceice June 19, 2023 13:15
…tion_work_for_PR_and_onboardPR_for_consistency
@viceice viceice changed the title refactor(config): Making suppression notification work for PR and onboardingPR for consistency fix(config): Making suppression notification work for PR and onboardingPR for consistency Jun 21, 2023
@viceice viceice added this pull request to the merge queue Jun 21, 2023
Merged via the queue into renovatebot:main with commit ae8bb71 Jun 21, 2023
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.138.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants