-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(platform): compare target refs before updating #23094
fix(platform): compare target refs before updating #23094
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this help?
I'm not seeing a logic change |
The issue is that Azure throws as error when we try to update targetBranch unnecessarily ie. trying to update it to same value. New change: |
I expected this to require a change of logic in workers |
I thought the same, and then coded it. After that I realised that the checks in the platform files is needed regardless of change in targetBranch so that we check targetBranch != undefined before passing value to the api call. So I decidedto make changes to platform files instead of workers and plaftorm files. |
Are you saying that |
Correct, workers change is needed. Feeling stupid now as that is that basic logic change that is must🤦♂️ |
🎉 This PR is included in version 35.159.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 35.159.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Changes
Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: