Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: includeMirrors #23110

Merged
merged 48 commits into from
Jul 9, 2023
Merged

feat: includeMirrors #23110

merged 48 commits into from
Jul 9, 2023

Conversation

Rainman73
Copy link
Contributor

Changes

Add support for 'includeMirrors' configuration option to allow Renovate to operate on (gitlab) repositories that are mirrors.

Context

Closes #16436

Documentation

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@Rainman73
add includeMirrors option
bed7641
@Rainman73
Merge branch 'renovatebot:main' into feat/16436-support-includeMirrors
bf5ac6f
@Rainman73
Merge branch 'renovatebot:main' into feat/16436-support-includeMirrors
0f96a69
@Rainman73
Merge branch 'renovatebot:main' into feat/16436-support-includeMirrors
a7c6637
@Rainman73
Merge branch 'renovatebot:main' into feat/16436-support-includeMirrors
fc6ddc7
@Rainman73
Merge branch 'renovatebot:main' into feat/16436-support-includeMirrors
c786cf1
@Rainman73
Merge branch 'renovatebot:main' into feat/16436-support-includeMirrors
ae16727
@Rainman73
Merge branch 'renovatebot:main' into feat/16436-support-includeMirrors
f0aef84
@Rainman73
Merge branch 'renovatebot:main' into feat/16436-support-includeMirrors
866eac2
@Rainman73
feat(16436): add testcase
3738de8
@Rainman73
Merge branch 'renovatebot:main' into feat/16436-support-includeMirrors
0739383
@Rainman73
Merge branch 'main' into feat/16436-support-includeMirrors
de03e62
@Rainman73
Copy link
Contributor Author

As you can probably tell, I'm not a JS/TS programmer. I'm open to suggestions for more idiomatic solutions.

@Rainman73 Rainman73 changed the title Feat/16436 support include mirrors feat: support includeMirrors to allow Renovate to operate on repositories that are mirrors Jul 3, 2023
rarkins
rarkins previously approved these changes Jul 3, 2023
View reviewed changes
rarkins
rarkins reviewed Jul 3, 2023
View reviewed changes
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it need to be globalOnly or can it work with repo config?

viceice
viceice reviewed Jul 3, 2023
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mirror repos are still filtered on autodiscover, check getRepos function

lib/modules/platform/gitlab/index.ts Outdated Show resolved Hide resolved
lib/modules/platform/gitlab/index.ts Outdated Show resolved Hide resolved
lib/modules/platform/gitlab/index.ts Outdated Show resolved Hide resolved
Rainman73 and others added 5 commits July 3, 2023 17:08
@Rainman73 @viceice
Update lib/modules/platform/gitlab/index.ts
699beff 
chore: incorporate review comments

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@Rainman73 @viceice
Update lib/modules/platform/gitlab/index.ts
baba8b1 
chore: incorporate review comments

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@Rainman73 @viceice
Update lib/modules/platform/gitlab/index.ts
ad9396c 
chore: incorporate review comments

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@Rainman73
Merge branch 'main' into feat/16436-support-includeMirrors
c23d641
@Rainman73
chore: restore test snapshots after rework
fbf9c8d
@Rainman73
Copy link
Contributor Author

Rainman73 commented Jul 3, 2023 •
edited

mirror repos are still filtered on autodiscover, check getRepos function

Good point, the .filter() needs to be updated there, but how do I get the value of the includeMirrors setting there? (Sorry for the newb question)

rarkins
rarkins requested changes Jul 4, 2023
View reviewed changes
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make global only

docs/usage/configuration-options.md Outdated Show resolved Hide resolved
lib/config/options/index.ts Show resolved Hide resolved
@rarkins rarkins changed the title feat: support includeMirrors to allow Renovate to operate on repositories that are mirrors feat: includeMirrors Jul 4, 2023
@Rainman73 @rarkins
Update docs/usage/self-hosted-configuration.md
f54009e 
Co-authored-by: Rhys Arkins <rhys@arkins.net>
@X-oss-byte
Copy link

Does it need to be globalOnly or can it work with repo config?

Globaly and repo config

@rarkins
Copy link
Collaborator

rarkins commented Jul 7, 2023

Global only.

rarkins
rarkins requested changes Jul 7, 2023
View reviewed changes
lib/modules/platform/gitlab/index.ts Outdated Show resolved Hide resolved
lib/modules/platform/gitlab/index.ts Outdated Show resolved Hide resolved
lib/modules/platform/gitlab/index.ts Show resolved Hide resolved
rarkins
rarkins previously approved these changes Jul 7, 2023
View reviewed changes
viceice
viceice reviewed Jul 7, 2023
View reviewed changes
lib/modules/platform/gitlab/index.ts Outdated Show resolved Hide resolved
lib/modules/platform/gitlab/index.ts Outdated Show resolved Hide resolved
lib/config/global.ts Outdated Show resolved Hide resolved
@rarkins rarkins requested a review from viceice July 8, 2023 05:46
@rarkins
Copy link
Collaborator

rarkins commented Jul 8, 2023

@Rainman73 please don't push from main branch unless you're making other changes. Each push resets the test approvals

@rarkins rarkins enabled auto-merge July 9, 2023 10:21
@rarkins rarkins added this pull request to the merge queue Jul 9, 2023
Merged via the queue into renovatebot:main with commit 12e8935 Jul 9, 2023
34 checks passed
@Rainman73 Rainman73 deleted the feat/16436-support-includeMirrors branch July 9, 2023 10:37
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 36.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot mentioned this pull request Jul 9, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rarkins rarkins rarkins approved these changes

@viceice viceice Awaiting requested review from viceice

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support includeMirrors
5 participants
@Rainman73 @rarkins @X-oss-byte @renovate-release @viceice