Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs for renovate/renovate Docker image #23143

Closed
2 tasks
HonkingGoose opened this issue Jul 4, 2023 · 9 comments
Closed
2 tasks

Update docs for renovate/renovate Docker image #23143

HonkingGoose opened this issue Jul 4, 2023 · 9 comments
Assignees
@rarkins
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:in-progress Someone is working on implementation type:docs Documentation

Comments

@HonkingGoose
Copy link
Collaborator

HonkingGoose commented Jul 4, 2023 •
edited

Describe the proposed change(s).

Update the Renovate docs:

  • Update Running Renovate
  • Update other text surrounding renovate/renovate Docker image references

Describe why we need/want these change(s).

renovatebot/docker-renovate released a breaking change to the published image:

I think this means we need to update our docs, because that image now points to -slim by default?
@HonkingGoose HonkingGoose added priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:docs Documentation status:ready labels Jul 4, 2023
@HonkingGoose
Copy link
Collaborator Author

HonkingGoose commented Jul 5, 2023 •
edited

@rarkins can you make the changes for this issue in the docs PR you just pinged me to review?

@rarkins
Copy link
Collaborator

rarkins commented Jul 5, 2023

I prefer to keep them separate so they don't get blocked for long

@rarkins
Copy link
Collaborator

rarkins commented Jul 5, 2023

Never mind, I added them to the existing

@viceice
Copy link
Member

viceice commented Jul 5, 2023

we should remove all references to slim and use normal tags. for full image we now need to use full or <version>-full tags

@viceice
Copy link
Member

viceice commented Jul 5, 2023

slim tags are deprecated

@rarkins
Copy link
Collaborator

rarkins commented Jul 5, 2023

I removed some more slim references from my PR

@rarkins rarkins self-assigned this Jul 5, 2023
@rarkins rarkins added status:in-progress Someone is working on implementation and removed status:ready labels Jul 5, 2023
@viceice
Copy link
Member

viceice commented Mar 18, 2024

What's missing here? 🤔

@HonkingGoose
Copy link
Collaborator Author

Maybe we've already done this work? I searched for the keyword slim and the hits I found seemed to be logical, but make sure to review this!

@viceice viceice closed this as completed Mar 18, 2024
@viceice
Copy link
Member

viceice commented Mar 18, 2024

I only find some unrelated test fixtures for slim

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rarkins rarkins

Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:in-progress Someone is working on implementation type:docs Documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@viceice @rarkins @HonkingGoose