Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(presets): Add monorepo Spectre.Console #23193

Merged
merged 2 commits into from
Jul 7, 2023
Merged

feat(presets): Add monorepo Spectre.Console #23193

merged 2 commits into from
Jul 7, 2023

Conversation

nils-a
Copy link
Contributor

@nils-a nils-a commented Jul 5, 2023

Changes

Added monorepo preset for Spectre.Console

Context

If multiple parts of Spectre.Console are consumed in a project, they should all be updated together.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins
Copy link
Collaborator

rarkins commented Jul 6, 2023

The library goes with the name Spectre.Console although I think we prefer to avoid dots in our group names? If so then we need to decide between SpectreConsole and Spectre-Console

@nils-a
Copy link
Contributor Author

nils-a commented Jul 6, 2023

@rarkins, using Spectre.Console also resulted it a bunch of linting errors about "namespaces" - that was the first thing I tried 😀

When creating the grouping manually, there's the groupName and the groupSluge, but I found nothing for the built-in groups to provide similar functionality.

In my local setups I currently use:

{
  "matchPackageNames": [
    "Spectre.Console",
    "Spectre.Console.Cli",
    "Spectre.Console.Testing",
    "Spectre.Console.ImageSharp",
    "Spectre.Console.Analyzer"
  ],
  "groupName": "Spectre.Console",
  "groupSlug": "spectre-console"
}

I'd rather prefer using SpectreConsole over Spectre-Console. On the other hand, I have also not found any other grouping here that uses capital letters. So, IMO, it comes down to either SpectreConsole which is - within the current frame - closest to the original naming of the project or spectre-console which would fit best in with all the other names currently in the file.
As I said, I'd love to see SpectreConsole, but I'll also go with whatever fits this project best.

@viceice
Copy link
Member

viceice commented Jul 7, 2023

it's our design decision to only use lower case and dashes for those groups.

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@nils-a
Copy link
Contributor Author

nils-a commented Jul 7, 2023

it's our design decision to only use lower case and dashes for those groups.

good to know.
I have accepted your suggested edit.

@rarkins rarkins added this pull request to the merge queue Jul 7, 2023
Merged via the queue into renovatebot:main with commit 38f0d4f Jul 7, 2023
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 36.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants