fix(pnpm): locked version extraction logic #23342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RahulGautamSingh
approved these changes
Jul 13, 2023
rarkins
approved these changes
Jul 13, 2023
|
@Obi-Dann thanks for your PR! |
|
🎉 This PR is included in version 36.8.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixing the issue described in #23341
Context
The package folder resolution didn't consider package.json located in subfolders.
I am changing a regex with
upathhelpers and calculating the package.json dir for pnpm relative to pnpm's lock file.There are 2 more tests to ensure this works as expected with pnpm-lock files in subfolder as well as with pnpm workspaces
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: