Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(managers): move regex in custom folder #23715

Merged
merged 12 commits into from Aug 6, 2023

Conversation

RahulGautamSingh
Copy link
Collaborator

@RahulGautamSingh RahulGautamSingh commented Aug 4, 2023

Changes

  • Moved regex manager in custom folder and modified the code in some test files, docs/manager.ts and manager-fingerprint generation as they depend on the file location of manager files

  • Also created the file custom/index.ts and exported constants and extractPackageFile fn from it to satisfy the manager module validation in tests.

  • I haven't included custom in the manager/api.ts, sincecustom is only a wrapper for custom managers and not an actual manager.

Context

Part of #19066
Tracked here: #19066 (comment)

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did I loose something or is this just a file move refactor PR?

lib/modules/manager/custom/regex/index.spec.ts Outdated Show resolved Hide resolved
tools/generate-imports.mjs Outdated Show resolved Hide resolved
@RahulGautamSingh
Copy link
Collaborator Author

did I loose something or is this just a file move refactor PR?

just a file move refactor

@RahulGautamSingh
Copy link
Collaborator Author

@rarkins rarkins added this pull request to the merge queue Aug 6, 2023
Merged via the queue into renovatebot:main with commit 9dc51d0 Aug 6, 2023
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 36.34.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants