refactor(enabled-managers): implement custom.<customMgrName> syntax
#24079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RahulGautamSingh
changed the title
RahulGautamSingh
changed the title
custom.<customMgrName> syntax for enabledManagers
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
|
I don't understan the reason behind the failing tests. It happened last time as well when trying to add |
lib/config/migrations/custom/enabled-managers-migration.spec.ts
Outdated
Show resolved
Hide resolved
|
@RahulGautamSingh ready to resume this? |
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
secustor
previously approved these changes
Oct 31, 2023
This comment was marked as outdated.
This comment was marked as outdated.
|
Test Runs: |
secustor
previously approved these changes
Nov 3, 2023
rarkins
reviewed
Nov 7, 2023
rarkins
previously approved these changes
Nov 7, 2023
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
rarkins
previously approved these changes
Nov 7, 2023
|
Is this a feature or a refactor? |
RahulGautamSingh
changed the title
custom.<customMgrName> syntax for enabledManagerscustom.<customMgrName> syntax
|
It's a rename so refactor. I got thinking that since its user facing I should use |
rarkins
approved these changes
Nov 8, 2023
|
🎉 This PR is included in version 37.51.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
jon4hz
pushed a commit
to jon4hz/renovate
that referenced
this pull request
Nov 9, 2023
…renovatebot#24079) Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com> Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
custom.<customMgrName>syntax forenabledManagersenabledManagers: ['regex'],enabledManagers: ['custom.regex']Context
_matchManagers was supposed to be done along with this but it needs a small typing change so it will done is a separate PR _
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: