Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(manager/helmsman): Add OCI support #24183

Merged
merged 12 commits into from Sep 8, 2023
Merged

feat(manager/helmsman): Add OCI support #24183

merged 12 commits into from Sep 8, 2023

Conversation

domolitom
Copy link
Contributor

@domolitom domolitom commented Aug 31, 2023 •
edited

Changes

With these changes, the helmsman manager is able to scan OCI registries.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

https://github.com/domolitom/renovate_oci_test

@CLAassistant
Copy link

CLAassistant commented Aug 31, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@domolitom domolitom changed the title oci support added to helmsman Feat: Add OCI support to helmsman manager Aug 31, 2023
@viceice viceice changed the title Feat: Add OCI support to helmsman manager feat: Add OCI support to helmsman manager Aug 31, 2023
viceice
viceice requested changes Aug 31, 2023
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign the CLA

@viceice viceice changed the title feat: Add OCI support to helmsman manager feat(manager/helmsman): Add OCI support Sep 4, 2023
viceice
viceice reviewed Sep 4, 2023
View reviewed changes
lib/modules/manager/helmsman/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/helmsman/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/helmsman/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/helmsman/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/helmsman/extract.ts Outdated Show resolved Hide resolved
viceice
viceice previously approved these changes Sep 5, 2023
View reviewed changes
auto-merge was automatically disabled September 5, 2023 11:17

Head branch was pushed to by a user without write access

viceice
viceice previously approved these changes Sep 5, 2023
View reviewed changes
@viceice
Copy link
Member

viceice commented Sep 5, 2023

still coverage issues

@viceice viceice added this pull request to the merge queue Sep 8, 2023
Merged via the queue into renovatebot:main with commit a65129f Sep 8, 2023
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 36.89.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@domolitom domolitom deleted the feat/helmsman_OCI_support branch September 11, 2023 12:24
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@domolitom @CLAassistant @viceice @renovate-release