Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: replacement PRs are now available for more managers #24293

Merged
merged 2 commits into from Sep 8, 2023
Merged

docs: replacement PRs are now available for more managers #24293

merged 2 commits into from Sep 8, 2023

Conversation

pdecat
Copy link
Contributor

@pdecat pdecat commented Sep 7, 2023 •
edited

Changes

This PR updates a statement on the main README.md that states replacements being only available for npm packages.

Context

#24277 (reply in thread)

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@pdecat pdecat changed the title fix(doc): update statement about replacement as they are now available for all managers fix(doc): update statement about replacements as they are now available for all managers Sep 7, 2023
HonkingGoose
HonkingGoose reviewed Sep 7, 2023
View reviewed changes
readme.md Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
@HonkingGoose HonkingGoose mentioned this pull request Sep 7, 2023
Closed
@pdecat @HonkingGoose
Renovate only supports replacement PRs for some managers right now
477ec42 
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@pdecat pdecat changed the title fix(doc): update statement about replacements as they are now available for all managers doc: replacement PRs are now available for more managers Sep 8, 2023
@pdecat
Copy link
Contributor Author

pdecat commented Sep 8, 2023

Thanks for the review @HonkingGoose! I've applied your suggestions, PTAL 🙏

HonkingGoose
HonkingGoose approved these changes Sep 8, 2023
View reviewed changes
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with the docs. I'll let the maintainers check if this is technically correct. 😉

@HonkingGoose
Copy link
Collaborator

I'm sorry, my Semantic Commit suggestion was wrong. 🙈 The correct prefix is docs: so with an extra s. Can you update the PR title again?

@pdecat pdecat changed the title doc: replacement PRs are now available for more managers docs: replacement PRs are now available for more managers Sep 8, 2023
@rarkins rarkins added this pull request to the merge queue Sep 8, 2023
Merged via the queue into renovatebot:main with commit 067ce29 Sep 8, 2023
36 checks passed
@HonkingGoose HonkingGoose mentioned this pull request Sep 8, 2023
Merged
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 36.88.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@pdecat pdecat deleted the patch-1 branch September 8, 2023 11:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rarkins rarkins rarkins approved these changes

@HonkingGoose HonkingGoose HonkingGoose approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pdecat @HonkingGoose @renovate-release @rarkins