Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(versioning): strip v prefix when bumping semver ranges #24357

Merged
merged 1 commit into from Sep 12, 2023

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Sep 11, 2023

Changes

Ensure v prefixes are stripped from npm semver ranges when bumping ranges

Context

Fixes #24346

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we also trim v when current value has no v but new value?

@rarkins
Copy link
Collaborator Author

rarkins commented Sep 11, 2023

do we also trim v when current value has no v but new value?

What do you mean by this?

I was wondering if there's any scenario where the v is meant to be there and is in the currentValue, but that doesn't seem to be the same as what you're asking

@viceice viceice added this pull request to the merge queue Sep 12, 2023
@viceice
Copy link
Member

viceice commented Sep 12, 2023

do we also trim v when current value has no v but new value?

What do you mean by this?

I was wondering if there's any scenario where the v is meant to be there and is in the currentValue, but that doesn't seem to be the same as what you're asking

never mind, would probably cause more edge cases and issues

Merged via the queue into main with commit 7d4de49 Sep 12, 2023
36 checks passed
@viceice viceice deleted the fix/24346-npm-v-prefix branch September 12, 2023 05:59
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 36.93.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants