Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bundler): Set exec cwd to lock file #24379

Merged
merged 5 commits into from Sep 13, 2023
Merged

fix(bundler): Set exec cwd to lock file #24379

merged 5 commits into from Sep 13, 2023

Conversation

jorge-wonolo
Copy link
Contributor

Changes

Execute bundler commands for artifacts based on lock file path.

Context

Given that Gemfile.lock is in the root directory of the project and Gemfile or Gemfiles are in subdirectories (e.g.: teamA/Gemfile) then bundler would have been executed under ./teamA path missing the root folder lock file and therefore only updating the Gemfile and not the lock file

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Tested against: jorge-wonolo/renovate-test#12

@jorge-wonolo jorge-wonolo mentioned this pull request Sep 12, 2023
Open
@jorge-wonolo jorge-wonolo changed the title fix(bundler) Set exec base path to be based off lock file fix(bundler): Set exec base path to be based off lock file Sep 12, 2023
daande
daande approved these changes Sep 12, 2023
View reviewed changes
Copy link

@daande daande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg2m

viceice
viceice previously approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably needs test changes

@jorge-wonolo
Copy link
Contributor Author

probably needs test changes

@viceice added a test, thanks for the suggestion

@viceice viceice changed the title fix(bundler): Set exec base path to be based off lock file fix(bundler): Set exec cwd to lock file Sep 13, 2023
@viceice viceice added this pull request to the merge queue Sep 13, 2023
Merged via the queue into renovatebot:main with commit ef504c0 Sep 13, 2023
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 36.93.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@daande daande daande approved these changes

@rarkins rarkins Awaiting requested review from rarkins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jorge-wonolo @renovate-release @viceice @daande @rarkins